Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/base/accelerators/accelerator_manager_unittest.cc

Issue 1155013005: Refactoring the ownership of ui::InputMethod. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments addressed. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ui/aura/window_tree_host_win.h ('K') | « ui/aura/window_tree_host_x11.cc ('k') | ui/base/ime/input_method_chromeos.cc » ('j') | ui/keyboard/keyboard_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/accelerators/accelerator_manager_unittest.cc
diff --git a/ui/base/accelerators/accelerator_manager_unittest.cc b/ui/base/accelerators/accelerator_manager_unittest.cc
index 1c3402d73e2b161fa4d018a5658424c451ad8b5a..1f8db027b139c0bfc3e3d251a6b0b4818ba049e0 100644
--- a/ui/base/accelerators/accelerator_manager_unittest.cc
+++ b/ui/base/accelerators/accelerator_manager_unittest.cc
@@ -151,12 +151,8 @@ TEST_F(AcceleratorManagerTest, Process) {
// The non-registered accelerators are not processed.
accelerator.set_type(ET_UNKNOWN);
EXPECT_FALSE(manager_.Process(accelerator)) << text; // different type
- accelerator.set_type(ET_TRANSLATED_KEY_PRESS);
- EXPECT_FALSE(manager_.Process(accelerator)) << text; // different type
accelerator.set_type(ET_KEY_RELEASED);
EXPECT_FALSE(manager_.Process(accelerator)) << text; // different type
- accelerator.set_type(ET_TRANSLATED_KEY_RELEASE);
- EXPECT_FALSE(manager_.Process(accelerator)) << text; // different type
EXPECT_FALSE(manager_.Process(GetAccelerator(VKEY_UNKNOWN, mask)))
<< text; // different vkey
« ui/aura/window_tree_host_win.h ('K') | « ui/aura/window_tree_host_x11.cc ('k') | ui/base/ime/input_method_chromeos.cc » ('j') | ui/keyboard/keyboard_util.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698