ash/wm/workspace/workspace_layout_manager.cc - Issue 1155013005: Refactoring the ownership of ui::InputMethod.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/workspace/workspace_layout_manager.cc

Issue 1155013005: Refactoring the ownership of ui::InputMethod. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments addressed. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/wm/workspace/workspace_layout_manager.cc

diff --git a/ash/wm/workspace/workspace_layout_manager.cc b/ash/wm/workspace/workspace_layout_manager.cc

index 63c4aed0e71112d817c63f2d2bd71d113efe85f6..c83e23ad75bf73d88c46dab0d7b259aaaf0f95db 100644

--- a/ash/wm/workspace/workspace_layout_manager.cc

+++ b/ash/wm/workspace/workspace_layout_manager.cc

@@ -134,8 +134,7 @@ void WorkspaceLayoutManager::SetChildBounds(

void WorkspaceLayoutManager::OnKeyboardBoundsChanging(

const gfx::Rect& new_bounds) {

- ui::InputMethod* input_method =

- root_window_->GetProperty(aura::client::kRootWindowInputMethodKey);

+ ui::InputMethod* input_method = root_window_->GetHost()->GetInputMethod();

ui::TextInputClient* text_input_client = input_method->GetTextInputClient();

if (!text_input_client)

return;