Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3573)

Unified Diff: ash/wm/overlay_event_filter.cc

Issue 1155013005: Refactoring the ownership of ui::InputMethod. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/overlay_event_filter.cc
diff --git a/ash/wm/overlay_event_filter.cc b/ash/wm/overlay_event_filter.cc
index b349bf99b621bf314e2e198a86c2a0b6281458b5..a728b9e1ac1fa3cf33507f77ec564a90454fcc97 100644
--- a/ash/wm/overlay_event_filter.cc
+++ b/ash/wm/overlay_event_filter.cc
@@ -23,13 +23,6 @@ void OverlayEventFilter::OnKeyEvent(ui::KeyEvent* event) {
if (!delegate_)
return;
- // Do not consume a translated key event which is generated by an IME (e.g.,
- // ui::VKEY_PROCESSKEY) since the key event is generated in response to a key
- // press or release before showing the ovelay. This is important not to
- // confuse key event handling JavaScript code in a page.
- if (event->IsTranslated())
- return;
-
if (delegate_ && delegate_->IsCancelingKeyEvent(event))
Cancel();

Powered by Google App Engine
This is Rietveld 408576698