Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: ui/events/event.h

Issue 1155013005: Refactoring the ownership of ui::InputMethod. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: pls be green! Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/events/event.h
diff --git a/ui/events/event.h b/ui/events/event.h
index 30d6cb56f6877548f9156038b69b4499455c12a6..26d890449aa7662c38bbf0912d4e8c526972bc68 100644
--- a/ui/events/event.h
+++ b/ui/events/event.h
@@ -95,9 +95,7 @@ class EVENTS_EXPORT Event {
bool IsKeyEvent() const {
return type_ == ET_KEY_PRESSED ||
- type_ == ET_KEY_RELEASED ||
- type_ == ET_TRANSLATED_KEY_PRESS ||
- type_ == ET_TRANSLATED_KEY_RELEASE;
+ type_ == ET_KEY_RELEASED;
}
bool IsMouseEvent() const {
@@ -602,8 +600,7 @@ class EVENTS_EXPORT ExtendedKeyEventData {
//
// For a keystroke event,
// -- is_char_ is false.
-// -- Event::type() can be any one of ET_KEY_PRESSED, ET_KEY_RELEASED,
-// ET_TRANSLATED_KEY_PRESS, or ET_TRANSLATED_KEY_RELEASE.
+// -- Event::type() can be any one of ET_KEY_PRESSED, ET_KEY_RELEASED.
// -- code_ and Event::flags() represent the physical key event.
// - code_ is a platform-independent representation of the physical key,
// based on DOM KeyboardEvent |code| values. It does not vary depending
@@ -744,12 +741,6 @@ class EVENTS_EXPORT KeyEvent : public Event {
// (Native X11 event flags describe the state before the event.)
void NormalizeFlags();
- // Returns true if the key event has already been processed by an input method
- // and there is no need to pass the key event to the input method again.
- bool IsTranslated() const;
James Cook 2015/06/01 22:21:00 Seeing things like this being removed makes me hap
Shu Chen 2015/06/02 04:11:16 Me too! :-)
- // Marks this key event as translated or not translated.
- void SetTranslated(bool translated);
-
protected:
friend class KeyEventTestApi;

Powered by Google App Engine
This is Rietveld 408576698