Refactoring the ownership of ui::InputMethod.

ui/events/event.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_EVENTS_EVENT_H_
 #define UI_EVENTS_EVENT_H_
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/event_types.h"
@@ skipping 77 matching lines @@
   bool IsShiftDown() const { return (flags_ & EF_SHIFT_DOWN) != 0; }
   bool IsControlDown() const { return (flags_ & EF_CONTROL_DOWN) != 0; }
   bool IsCapsLockDown() const { return (flags_ & EF_CAPS_LOCK_DOWN) != 0; }
   bool IsAltDown() const { return (flags_ & EF_ALT_DOWN) != 0; }
   bool IsAltGrDown() const { return (flags_ & EF_ALTGR_DOWN) != 0; }
   bool IsCommandDown() const { return (flags_ & EF_COMMAND_DOWN) != 0; }
   bool IsRepeat() const { return (flags_ & EF_IS_REPEAT) != 0; }
 
   bool IsKeyEvent() const {
     return type_ == ET_KEY_PRESSED ||
-           type_ == ET_KEY_RELEASED ||
-           type_ == ET_TRANSLATED_KEY_PRESS ||
-           type_ == ET_TRANSLATED_KEY_RELEASE;
+           type_ == ET_KEY_RELEASED;
   }
 
   bool IsMouseEvent() const {
     return type_ == ET_MOUSE_PRESSED ||
            type_ == ET_MOUSE_DRAGGED ||
            type_ == ET_MOUSE_RELEASED ||
            type_ == ET_MOUSE_MOVED ||
            type_ == ET_MOUSE_ENTERED ||
            type_ == ET_MOUSE_EXITED ||
            type_ == ET_MOUSEWHEEL ||
@@ skipping 484 matching lines @@
 
   virtual ExtendedKeyEventData* Clone() const = 0;
 };
 
 // A KeyEvent is really two distinct classes, melded together due to the
 // DOM legacy of Windows key events: a keystroke event (is_char_ == false),
 // or a character event (is_char_ == true).
 //
 // For a keystroke event,
 // -- is_char_ is false.
-// -- Event::type() can be any one of ET_KEY_PRESSED, ET_KEY_RELEASED,
-//    ET_TRANSLATED_KEY_PRESS, or ET_TRANSLATED_KEY_RELEASE.
+// -- Event::type() can be any one of ET_KEY_PRESSED, ET_KEY_RELEASED.
 // -- code_ and Event::flags() represent the physical key event.
 //    - code_ is a platform-independent representation of the physical key,
 //      based on DOM KeyboardEvent |code| values. It does not vary depending
 //      on key layout.
 //    - Event::flags() provides the active modifiers for the physical key
 //      press. Its value reflects the state after the event; that is, for
 //      a modifier key, a press includes the corresponding flag and a release
 //      does not.
 // -- key_ and character_ provide the meaning of the key event, in the context
 //    of the active layout and modifiers. Together they correspond to DOM
@@ skipping 120 matching lines @@
   DomCode code() const { return code_; };
   std::string GetCodeString() const;
 
   // Returns the DOM .key (layout meaning) for a keystroke event.
   DomKey GetDomKey() const;
 
   // Normalizes flags_ so that it describes the state after the event.
   // (Native X11 event flags describe the state before the event.)
   void NormalizeFlags();
 
-  // Returns true if the key event has already been processed by an input method
-  // and there is no need to pass the key event to the input method again.
-  bool IsTranslated() const;

[James Cook, 2015/06/01 22:21:00]

Seeing things like this being removed makes me happy!

[Shu Chen, 2015/06/02 04:11:16]

Me too! :-)

-  // Marks this key event as translated or not translated.
-  void SetTranslated(bool translated);
-
  protected:
   friend class KeyEventTestApi;
 
   // This allows a subclass TranslatedKeyEvent to be a non character event.
   void set_is_char(bool is_char) { is_char_ = is_char; }
 
  private:
   // Determine key_ and character_ on a keystroke event from code_ and flags().
   void ApplyLayout() const;
 
@@ skipping 116 matching lines @@
 
   const GestureEventDetails& details() const { return details_; }
 
  private:
   GestureEventDetails details_;
 };
 
 }  // namespace ui
 
 #endif  // UI_EVENTS_EVENT_H_