Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3268)

Unified Diff: cc/pinch_zoom_scrollbar_geometry.h

Issue 11550035: Implement pinch-zoom scaling for main-frame scrollbars and pinch-zoom overlay scrollbars. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix impl-side painting issues. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/pinch_zoom_scrollbar_geometry.h
diff --git a/cc/pinch_zoom_scrollbar_geometry.h b/cc/pinch_zoom_scrollbar_geometry.h
new file mode 100644
index 0000000000000000000000000000000000000000..b649044d300279252337caa1cc11ace972fcd915
--- /dev/null
+++ b/cc/pinch_zoom_scrollbar_geometry.h
@@ -0,0 +1,58 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CC_PINCH_ZOOM_SCROLLBAR_GEOMETRY_H_
+#define CC_PINCH_ZOOM_SCROLLBAR_GEOMETRY_H_
+
+#include "cc/cc_export.h"
+#include "third_party/WebKit/Source/Platform/chromium/public/WebScrollbarThemeGeometry.h"
+
+namespace WebKit {
jamesr 2013/02/26 20:48:46 Code in cc/ should be in namespace cc::
wjmaclean 2013/03/01 15:30:32 Done.
+
+class CC_EXPORT PinchZoomScrollbarGeometry : public WebScrollbarThemeGeometry {
+ public:
+ virtual ~PinchZoomScrollbarGeometry() {}
+
+ const int kTrackWidth = 10;
jamesr 2013/02/26 20:48:46 Another duplicate?
wjmaclean 2013/03/01 15:30:32 Fixed. I forgot I had two. I removed the one in P
+
+ virtual WebScrollbarThemeGeometry* clone() const OVERRIDE;
jamesr 2013/02/26 20:48:46 Same comments as above re OVERRIDE and comment
wjmaclean 2013/03/01 15:30:32 Done.
+ virtual int thumbPosition(WebScrollbar*) OVERRIDE;
jamesr 2013/02/26 20:48:46 In chromium style all parameters have names
wjmaclean 2013/03/01 15:30:32 Done.
+ virtual int thumbLength(WebScrollbar*) OVERRIDE;
+ virtual int trackPosition(WebScrollbar*) OVERRIDE;
+ virtual int trackLength(WebScrollbar*) OVERRIDE;
+ virtual bool hasButtons(WebScrollbar*) OVERRIDE { return false; }
jamesr 2013/02/26 20:48:46 In chromium style, all overrides with code (even i
wjmaclean 2013/03/01 15:30:32 Done.
+ virtual bool hasThumb(WebScrollbar*) OVERRIDE { return true; }
+ virtual WebRect trackRect(WebScrollbar*) OVERRIDE;
+ virtual WebRect thumbRect(WebScrollbar*) OVERRIDE;
+ virtual int minimumThumbLength(WebScrollbar*) OVERRIDE;
+ virtual int scrollbarThickness(WebScrollbar*) OVERRIDE;
+ virtual WebRect backButtonStartRect(WebScrollbar*) OVERRIDE
+ {
+ return WebRect();
+ }
+
+ virtual WebRect backButtonEndRect(WebScrollbar*) OVERRIDE
+ {
+ return WebRect();
+ }
+
+ virtual WebRect forwardButtonStartRect(WebScrollbar*) OVERRIDE
+ {
+ return WebRect();
+ }
+
+ virtual WebRect forwardButtonEndRect(WebScrollbar*) OVERRIDE {
+ return WebRect();
+ }
+
+ virtual WebRect constrainTrackRectToTrackPieces(WebScrollbar*, const WebRect&)
+ OVERRIDE;
+ virtual void splitTrack(
jamesr 2013/02/26 20:48:46 newline between functions
wjmaclean 2013/03/01 15:30:32 Done.
+ WebScrollbar*, const WebRect& track, WebRect& startTrack, WebRect& thumb,
+ WebRect& endTrack) OVERRIDE;
+
+};
+
+} // namespace WebKit
+#endif // CC_PINCH_ZOOM_SCROLLBAR_GEOMETRY_H_

Powered by Google App Engine
This is Rietveld 408576698