Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1743)

Unified Diff: cc/scrollbar_layer.cc

Issue 11550035: Implement pinch-zoom scaling for main-frame scrollbars and pinch-zoom overlay scrollbars. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Revised architecture - complete cl for comments on approach. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/scrollbar_layer.cc
diff --git a/cc/scrollbar_layer.cc b/cc/scrollbar_layer.cc
index 6fad23cb11481dd7b64811a269b10d5fe873779f..d4479061f7525f5a9eece799ee6855e6995a8a39 100644
--- a/cc/scrollbar_layer.cc
+++ b/cc/scrollbar_layer.cc
@@ -17,6 +17,9 @@
namespace cc {
+scoped_ptr<WebKit::WebScrollbarThemeGeometry> ScrollbarLayer::s_defaultGeometry;
+bool ScrollbarLayer::s_usesOverlayScrollbars = false;
+
scoped_ptr<LayerImpl> ScrollbarLayer::createLayerImpl(LayerTreeImpl* treeImpl)
{
return ScrollbarLayerImpl::create(treeImpl, id(), ScrollbarGeometryFixedThumb::create(make_scoped_ptr(m_geometry->clone()))).PassAs<LayerImpl>();
@@ -26,21 +29,54 @@ scoped_refptr<ScrollbarLayer> ScrollbarLayer::create(
scoped_ptr<WebKit::WebScrollbar> scrollbar,
scoped_ptr<ScrollbarThemePainter> painter,
scoped_ptr<WebKit::WebScrollbarThemeGeometry> geometry,
+ int scrollLayerId, bool isPinchZoomScrollbar)
+{
+ return make_scoped_refptr(new ScrollbarLayer(scrollbar.Pass(), painter.Pass(), geometry.Pass(), scrollLayerId, isPinchZoomScrollbar));
+}
+
+scoped_refptr<ScrollbarLayer> ScrollbarLayer::create(
+ scoped_ptr<WebKit::WebScrollbar> scrollbar,
+ scoped_ptr<ScrollbarThemePainter> painter,
int scrollLayerId)
{
- return make_scoped_refptr(new ScrollbarLayer(scrollbar.Pass(), painter.Pass(), geometry.Pass(), scrollLayerId));
+ if (!s_defaultGeometry)
+ return make_scoped_refptr(static_cast<ScrollbarLayer*>(0));
+ return create(scrollbar.Pass(), painter.Pass(),
+ make_scoped_ptr(s_defaultGeometry->clone()).Pass(),
+ scrollLayerId, true);
+}
+
+void ScrollbarLayer::setDefaultGeometry(
+ WebKit::WebScrollbarThemeGeometry* themeGeometry)
+{
+ // We assume themeGeometry is ours to own.
+ if (themeGeometry)
+ s_defaultGeometry = make_scoped_ptr(themeGeometry);
+}
+
+WebKit::WebScrollbarThemeGeometry* ScrollbarLayer::cloneDefaultGeometry()
+{
+ if (s_defaultGeometry)
+ return s_defaultGeometry->clone();
+ return 0;
+}
+
+void ScrollbarLayer::setDefaultUsesOverlayScrollbars(bool usesOverlayScrollbars)
+{
+ s_usesOverlayScrollbars = usesOverlayScrollbars;
}
ScrollbarLayer::ScrollbarLayer(
scoped_ptr<WebKit::WebScrollbar> scrollbar,
scoped_ptr<ScrollbarThemePainter> painter,
scoped_ptr<WebKit::WebScrollbarThemeGeometry> geometry,
- int scrollLayerId)
+ int scrollLayerId, bool isPinchZoomScrollbar)
: m_scrollbar(scrollbar.Pass())
, m_painter(painter.Pass())
, m_geometry(geometry.Pass())
, m_scrollLayerId(scrollLayerId)
, m_textureFormat(GL_INVALID_ENUM)
+ , m_isPinchZoomScrollbar(isPinchZoomScrollbar)
{
if (!m_scrollbar->isOverlay())
setShouldScrollOnMainThread(true);
@@ -123,6 +159,8 @@ void ScrollbarLayer::pushPropertiesTo(LayerImpl* layer)
scrollbarLayer->setThumbResourceId(m_thumb->texture()->resourceId());
else
scrollbarLayer->setThumbResourceId(0);
+
+ scrollbarLayer->setIsPinchZoomScrollbar(m_isPinchZoomScrollbar);
}
ScrollbarLayer* ScrollbarLayer::toScrollbarLayer()
« cc/scrollbar_layer.h ('K') | « cc/scrollbar_layer.h ('k') | cc/scrollbar_layer_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698