Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Side by Side Diff: cc/pinch_zoom_scrollbar_geometry.h

Issue 11550035: Implement pinch-zoom scaling for main-frame scrollbars and pinch-zoom overlay scrollbars. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix impl-side painting issues. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CC_PINCH_ZOOM_SCROLLBAR_GEOMETRY_H_
6 #define CC_PINCH_ZOOM_SCROLLBAR_GEOMETRY_H_
7
8 #include "cc/cc_export.h"
9 #include "third_party/WebKit/Source/Platform/chromium/public/WebScrollbarThemeGe ometry.h"
10
11 namespace WebKit {
jamesr 2013/02/26 20:48:46 Code in cc/ should be in namespace cc::
wjmaclean 2013/03/01 15:30:32 Done.
12
13 class CC_EXPORT PinchZoomScrollbarGeometry : public WebScrollbarThemeGeometry {
14 public:
15 virtual ~PinchZoomScrollbarGeometry() {}
16
17 const int kTrackWidth = 10;
jamesr 2013/02/26 20:48:46 Another duplicate?
wjmaclean 2013/03/01 15:30:32 Fixed. I forgot I had two. I removed the one in P
18
19 virtual WebScrollbarThemeGeometry* clone() const OVERRIDE;
jamesr 2013/02/26 20:48:46 Same comments as above re OVERRIDE and comment
wjmaclean 2013/03/01 15:30:32 Done.
20 virtual int thumbPosition(WebScrollbar*) OVERRIDE;
jamesr 2013/02/26 20:48:46 In chromium style all parameters have names
wjmaclean 2013/03/01 15:30:32 Done.
21 virtual int thumbLength(WebScrollbar*) OVERRIDE;
22 virtual int trackPosition(WebScrollbar*) OVERRIDE;
23 virtual int trackLength(WebScrollbar*) OVERRIDE;
24 virtual bool hasButtons(WebScrollbar*) OVERRIDE { return false; }
jamesr 2013/02/26 20:48:46 In chromium style, all overrides with code (even i
wjmaclean 2013/03/01 15:30:32 Done.
25 virtual bool hasThumb(WebScrollbar*) OVERRIDE { return true; }
26 virtual WebRect trackRect(WebScrollbar*) OVERRIDE;
27 virtual WebRect thumbRect(WebScrollbar*) OVERRIDE;
28 virtual int minimumThumbLength(WebScrollbar*) OVERRIDE;
29 virtual int scrollbarThickness(WebScrollbar*) OVERRIDE;
30 virtual WebRect backButtonStartRect(WebScrollbar*) OVERRIDE
31 {
32 return WebRect();
33 }
34
35 virtual WebRect backButtonEndRect(WebScrollbar*) OVERRIDE
36 {
37 return WebRect();
38 }
39
40 virtual WebRect forwardButtonStartRect(WebScrollbar*) OVERRIDE
41 {
42 return WebRect();
43 }
44
45 virtual WebRect forwardButtonEndRect(WebScrollbar*) OVERRIDE {
46 return WebRect();
47 }
48
49 virtual WebRect constrainTrackRectToTrackPieces(WebScrollbar*, const WebRect&)
50 OVERRIDE;
51 virtual void splitTrack(
jamesr 2013/02/26 20:48:46 newline between functions
wjmaclean 2013/03/01 15:30:32 Done.
52 WebScrollbar*, const WebRect& track, WebRect& startTrack, WebRect& thumb,
53 WebRect& endTrack) OVERRIDE;
54
55 };
56
57 } // namespace WebKit
58 #endif // CC_PINCH_ZOOM_SCROLLBAR_GEOMETRY_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698