Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: content/public/test/test_browser_context.cc

Issue 11550031: Implement SequenceChecker, which is a generalization of ThreadChecker (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/sequence_checker_impl_unittest.cc ('K') | « base/test/null_task_runner.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/test/test_browser_context.cc
diff --git a/content/public/test/test_browser_context.cc b/content/public/test/test_browser_context.cc
index 2269812aeb678d6709108cd923bba29ec48f8eb7..ec47813b15d0f3d0453904033f65cdd27cd7ceb3 100644
--- a/content/public/test/test_browser_context.cc
+++ b/content/public/test/test_browser_context.cc
@@ -5,6 +5,7 @@
#include "content/public/test/test_browser_context.h"
#include "base/file_path.h"
+#include "base/test/null_task_runner.h"
#include "content/public/test/mock_resource_context.h"
#include "net/url_request/url_request_context.h"
#include "net/url_request/url_request_context_getter.h"
@@ -13,39 +14,11 @@
namespace {
-// A silly class to satisfy net::URLRequestsContextGetter requirement
-// for a task runner. Threading requirements don't matter for this
-// test scaffolding.
-class AnyThreadNonTaskRunner : public base::SingleThreadTaskRunner {
- public:
- virtual bool RunsTasksOnCurrentThread() const OVERRIDE {
- return true;
- }
-
- virtual bool PostDelayedTask(const tracked_objects::Location& from_here,
- const base::Closure& task,
- base::TimeDelta delay) OVERRIDE {
- NOTREACHED();
- return false;
- }
-
- virtual bool PostNonNestableDelayedTask(
- const tracked_objects::Location& from_here,
- const base::Closure& task,
- base::TimeDelta delay) OVERRIDE {
- NOTREACHED();
- return false;
- }
-
- private:
- virtual ~AnyThreadNonTaskRunner() {}
-};
-
class TestContextURLRequestContextGetter : public net::URLRequestContextGetter {
public:
explicit TestContextURLRequestContextGetter(net::URLRequestContext* context)
: context_(context),
- any_thread_non_task_runner_(new AnyThreadNonTaskRunner) {
+ null_task_runner_(new base::NullTaskRunner) {
}
virtual net::URLRequestContext* GetURLRequestContext() OVERRIDE {
@@ -54,14 +27,14 @@ class TestContextURLRequestContextGetter : public net::URLRequestContextGetter {
virtual scoped_refptr<base::SingleThreadTaskRunner>
GetNetworkTaskRunner() const OVERRIDE {
- return any_thread_non_task_runner_;
+ return null_task_runner_;
}
private:
virtual ~TestContextURLRequestContextGetter() {}
net::URLRequestContext* context_;
- scoped_refptr<base::SingleThreadTaskRunner> any_thread_non_task_runner_;
+ scoped_refptr<base::SingleThreadTaskRunner> null_task_runner_;
};
} // namespace
« base/sequence_checker_impl_unittest.cc ('K') | « base/test/null_task_runner.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698