Remove partial magnifier from settings page.

Remove partial magnifier from settings page.

Partial magnifier won't be on R25, so its settings should be hidden from chrome://settings.

BUG=165331
TEST=verify the setting is removed and magnifier is controllable via chrome:settings, system menu and oobe. browser_tests passes.

TBR=dbeam@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173449

[yoshiki, 2012-12-12 16:39:43]

@dbeam: Could you take a look? Thanks,

[Dan Beam, 2012-12-12 21:24:11]

can you change the pref to a boolean pref instead? has this ever made it to
stable or anywhere that'd be a bad idea?

https://codereview.chromium.org/11550010/diff/1/chrome/browser/resources/opti...
File chrome/browser/resources/options/browser_options.js (right):

https://codereview.chromium.org/11550010/diff/1/chrome/browser/resources/opti...
chrome/browser/resources/options/browser_options.js:1189: * Set the initial
state of the screen magnifier dropdown.
* @param {string} type Explain the type here.

[yoshiki, 2012-12-13 02:40:26]

I want to disable a partial magnifier just at M25 branch point and this patch
will be reverted after the branch point. Hence I'd like not to change the pref.

https://codereview.chromium.org/11550010/diff/1/chrome/browser/resources/opti...
File chrome/browser/resources/options/browser_options.js (right):

https://codereview.chromium.org/11550010/diff/1/chrome/browser/resources/opti...
chrome/browser/resources/options/browser_options.js:1189: * Set the initial
state of the screen magnifier dropdown.
On 2012/12/12 21:24:11, Dan Beam wrote:
> * @param {string} type Explain the type here.

Done.

[Dan Beam, 2012-12-14 04:12:43]

On 2012/12/13 02:40:26, yoshiki wrote:
> I want to disable a partial magnifier just at M25 branch point and this patch
> will be reverted after the branch point. Hence I'd like not to change the
pref.

Writing pref migration code is harder than not writing pref migration code.  Why
are you keeping it this way for M25?  Has this pref ever hit stable?

> 
>
https://codereview.chromium.org/11550010/diff/1/chrome/browser/resources/opti...
> File chrome/browser/resources/options/browser_options.js (right):
> 
>
https://codereview.chromium.org/11550010/diff/1/chrome/browser/resources/opti...
> chrome/browser/resources/options/browser_options.js:1189: * Set the initial
> state of the screen magnifier dropdown.
> On 2012/12/12 21:24:11, Dan Beam wrote:
> > * @param {string} type Explain the type here.
> 
> Done.

[yoshiki, 2012-12-14 06:50:49]

Sorry, I misunderstood. You are right, the boolean pref
(setting.a11y.screen_magnifier) has been used until M24 and changing it back to
boolean is good way.

On 2012/12/14 04:12:43, Dan Beam wrote:
> On 2012/12/13 02:40:26, yoshiki wrote:
> > I want to disable a partial magnifier just at M25 branch point and this
patch
> > will be reverted after the branch point. Hence I'd like not to change the
> pref.
> 
> Writing pref migration code is harder than not writing pref migration code. 
Why
> are you keeping it this way for M25?  Has this pref ever hit stable?
> 
> > 
> >
>
https://codereview.chromium.org/11550010/diff/1/chrome/browser/resources/opti...
> > File chrome/browser/resources/options/browser_options.js (right):
> > 
> >
>
https://codereview.chromium.org/11550010/diff/1/chrome/browser/resources/opti...
> > chrome/browser/resources/options/browser_options.js:1189: * Set the initial
> > state of the screen magnifier dropdown.
> > On 2012/12/12 21:24:11, Dan Beam wrote:
> > > * @param {string} type Explain the type here.
> > 
> > Done.

[yoshiki, 2012-12-17 02:26:32]

@dbeam: ping?

On 2012/12/14 06:50:49, yoshiki wrote:
> Sorry, I misunderstood. You are right, the boolean pref
> (setting.a11y.screen_magnifier) has been used until M24 and changing it back
to
> boolean is good way.
> 
> On 2012/12/14 04:12:43, Dan Beam wrote:
> > On 2012/12/13 02:40:26, yoshiki wrote:
> > > I want to disable a partial magnifier just at M25 branch point and this
> patch
> > > will be reverted after the branch point. Hence I'd like not to change the
> > pref.
> > 
> > Writing pref migration code is harder than not writing pref migration code. 
> Why
> > are you keeping it this way for M25?  Has this pref ever hit stable?
> > 
> > > 
> > >
> >
>
https://codereview.chromium.org/11550010/diff/1/chrome/browser/resources/opti...
> > > File chrome/browser/resources/options/browser_options.js (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/11550010/diff/1/chrome/browser/resources/opti...
> > > chrome/browser/resources/options/browser_options.js:1189: * Set the
initial
> > > state of the screen magnifier dropdown.
> > > On 2012/12/12 21:24:11, Dan Beam wrote:
> > > > * @param {string} type Explain the type here.
> > > 
> > > Done.

[yoshiki, 2012-12-17 06:48:01]

@zork: could you review the accessibility part? Thanks,

[Zachary Kuznia, 2012-12-17 09:16:43]

lgtm

[yoshiki, 2012-12-17 09:20:52]

@dbeam: adding you TBR and commit this since I want this to be in before the
branch point. Thanks,

[commit-bot: I haz the power, 2012-12-17 09:21:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/11550010/13008

[commit-bot: I haz the power, 2012-12-17 12:07:44]

Change committed as 173449