Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Side by Side Diff: src/arm/lithium-codegen-arm.cc

Issue 11550005: Elide unnecessary context reload in generated stubs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Review feedback Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/code-stubs-hydrogen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2802 matching lines...) Expand 10 before | Expand all | Expand 10 after
2813 // Runtime::TraceExit returns its parameter in r0. 2813 // Runtime::TraceExit returns its parameter in r0.
2814 __ push(r0); 2814 __ push(r0);
2815 __ CallRuntime(Runtime::kTraceExit, 1); 2815 __ CallRuntime(Runtime::kTraceExit, 1);
2816 } 2816 }
2817 if (NeedsEagerFrame()) { 2817 if (NeedsEagerFrame()) {
2818 int32_t sp_delta = (GetParameterCount() + 1) * kPointerSize; 2818 int32_t sp_delta = (GetParameterCount() + 1) * kPointerSize;
2819 __ mov(sp, fp); 2819 __ mov(sp, fp);
2820 __ ldm(ia_w, sp, fp.bit() | lr.bit()); 2820 __ ldm(ia_w, sp, fp.bit() | lr.bit());
2821 __ add(sp, sp, Operand(sp_delta)); 2821 __ add(sp, sp, Operand(sp_delta));
2822 } 2822 }
2823 if (info()->IsStub()) {
2824 __ ldr(cp, MemOperand(fp, StandardFrameConstants::kContextOffset));
2825 }
2826 __ Jump(lr); 2823 __ Jump(lr);
2827 } 2824 }
2828 2825
2829 2826
2830 void LCodeGen::DoLoadGlobalCell(LLoadGlobalCell* instr) { 2827 void LCodeGen::DoLoadGlobalCell(LLoadGlobalCell* instr) {
2831 Register result = ToRegister(instr->result()); 2828 Register result = ToRegister(instr->result());
2832 __ mov(ip, Operand(Handle<Object>(instr->hydrogen()->cell()))); 2829 __ mov(ip, Operand(Handle<Object>(instr->hydrogen()->cell())));
2833 __ ldr(result, FieldMemOperand(ip, JSGlobalPropertyCell::kValueOffset)); 2830 __ ldr(result, FieldMemOperand(ip, JSGlobalPropertyCell::kValueOffset));
2834 if (instr->hydrogen()->RequiresHoleCheck()) { 2831 if (instr->hydrogen()->RequiresHoleCheck()) {
2835 __ LoadRoot(ip, Heap::kTheHoleValueRootIndex); 2832 __ LoadRoot(ip, Heap::kTheHoleValueRootIndex);
(...skipping 3249 matching lines...) Expand 10 before | Expand all | Expand 10 after
6085 __ sub(scratch, result, Operand(index, LSL, kPointerSizeLog2 - kSmiTagSize)); 6082 __ sub(scratch, result, Operand(index, LSL, kPointerSizeLog2 - kSmiTagSize));
6086 __ ldr(result, FieldMemOperand(scratch, 6083 __ ldr(result, FieldMemOperand(scratch,
6087 FixedArray::kHeaderSize - kPointerSize)); 6084 FixedArray::kHeaderSize - kPointerSize));
6088 __ bind(&done); 6085 __ bind(&done);
6089 } 6086 }
6090 6087
6091 6088
6092 #undef __ 6089 #undef __
6093 6090
6094 } } // namespace v8::internal 6091 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/code-stubs-hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698