Issue 11550005: Elide unnecessary context reload in generated stubs.

Issue 11550005: Elide unnecessary context reload in generated stubs. (Closed)

Created:
8 years ago by danno

Modified:
7 years, 12 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Elide unnecessary context reload in generated stubs. Committed: http://code.google.com/p/v8/source/detail?r=13290

Patch Set 3 : Merge with ToT #

Total comments: 4

Patch Set 4 : Review feedback #

Created: 7 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -23 lines)			Patch
M	src/arm/lithium-arm.cc	View	1 2 3	1 chunk	+8 lines, -1 line	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1 2 3	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/code-stubs-hydrogen.cc	View	1 2	3 chunks	+7 lines, -2 lines	0 comments	Download
M	src/hydrogen.cc	View	1 2 3	2 chunks	+5 lines, -2 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	1 2	2 chunks	+4 lines, -2 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 2 3	3 chunks	+9 lines, -5 lines	0 comments	Download
M	src/ia32/lithium-ia32.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View		2 chunks	+11 lines, -2 lines	0 comments	Download
M	src/lithium.h	View	1 2 3	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/lithium-allocator-inl.h	View	1 2 3	3 chunks	+7 lines, -2 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/x64/lithium-x64.cc	View		1 chunk	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ulan

LGTM with two nits. https://chromiumcodereview.appspot.com/11550005/diff/4001/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): https://chromiumcodereview.appspot.com/11550005/diff/4001/src/ia32/lithium-codegen-ia32.cc#newcode807 src/ia32/lithium-codegen-ia32.cc:807: Deoptimizer::BailoutType bailout_type = info()->IsOptimizing() Maybe ...

7 years, 12 months ago (2012-12-28 15:40:49 UTC) #2

danno

7 years, 12 months ago (2012-12-28 17:38:41 UTC) #3

Message was sent while issue was closed.

Feedback addressed, landing

https://codereview.chromium.org/11550005/diff/4001/src/ia32/lithium-codegen-i...
File src/ia32/lithium-codegen-ia32.cc (right):

https://codereview.chromium.org/11550005/diff/4001/src/ia32/lithium-codegen-i...
src/ia32/lithium-codegen-ia32.cc:807: Deoptimizer::BailoutType bailout_type =
info()->IsOptimizing()
On 2012/12/28 15:40:49, ulan wrote:
> Maybe negate this and use info()->IsStub() to make it similar to x64 and arm?

Done.

https://codereview.chromium.org/11550005/diff/4001/src/lithium-allocator-inl.h
File src/lithium-allocator-inl.h (right):

https://codereview.chromium.org/11550005/diff/4001/src/lithium-allocator-inl....
src/lithium-allocator-inl.h:115: (current = instr_->InputAt(current_)) != NULL
&&
On 2012/12/28 15:40:49, ulan wrote:
> Looks like we can make NULL operands uninteresting by changing it to ((current
=
> instr_->InputAt(current_)) == NULL || current->IsConstantOperand()).
> Then we can avoid if (it.Current() == NULL) checks in the .cc file.

Done.

Expand Messages | Collapse Messages