Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: Source/bindings/core/v8/Dictionary.cpp

Issue 1154943009: bindings: Remove [EventConstructor] and [InitializedByEventConstructor] (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/Dictionary.cpp
diff --git a/Source/bindings/core/v8/Dictionary.cpp b/Source/bindings/core/v8/Dictionary.cpp
index 3e32a7115bb6c989b79111a7fcc5bd436fd2e485..7023763ed5790ed3415499646fb083b61ec7e905 100644
--- a/Source/bindings/core/v8/Dictionary.cpp
+++ b/Source/bindings/core/v8/Dictionary.cpp
@@ -153,24 +153,6 @@ bool Dictionary::get(const String& key, Dictionary& value) const
return true;
}
-bool Dictionary::convert(ConversionContext& context, const String& key, Dictionary& value) const
-{
- ConversionContextScope scope(context);
-
- v8::Local<v8::Value> v8Value;
- if (!getKey(key, v8Value))
- return true;
-
- if (v8Value->IsObject())
- return get(key, value);
-
- if (context.isNullable() && blink::isUndefinedOrNull(v8Value))
- return true;
-
- context.throwTypeError(ExceptionMessages::incorrectPropertyType(key, "does not have a Dictionary type."));
- return false;
-}
-
static inline bool propertyKey(v8::Local<v8::Context> v8Context, v8::Local<v8::Array> properties, uint32_t index, v8::Local<v8::String>& key)
{
v8::Local<v8::Value> property;
@@ -229,30 +211,6 @@ bool Dictionary::getPropertyNames(Vector<String>& names) const
return true;
}
-void Dictionary::ConversionContext::resetPerPropertyContext()
-{
- if (m_dirty) {
- m_dirty = false;
- m_isNullable = false;
- m_propertyTypeName = "";
- }
-}
-
-Dictionary::ConversionContext& Dictionary::ConversionContext::setConversionType(const String& typeName, bool isNullable)
-{
- ASSERT(!m_dirty);
- m_dirty = true;
- m_isNullable = isNullable;
- m_propertyTypeName = typeName;
-
- return *this;
-}
-
-void Dictionary::ConversionContext::throwTypeError(const String& detail)
-{
- exceptionState().throwTypeError(detail);
-}
-
bool Dictionary::toObject(v8::Local<v8::Object>& object) const
{
return !isUndefinedOrNull() && m_options->ToObject(v8Context()).ToLocal(&object);

Powered by Google App Engine
This is Rietveld 408576698