Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1154943009: bindings: Remove [EventConstructor] and [InitializedByEventConstructor] (Closed)

Created:
5 years, 6 months ago by bashi
Modified:
5 years, 6 months ago
Reviewers:
haraken, tasak
CC:
blink-reviews, blink-reviews-dom_chromium.org, arv+blink, vivekg_samsung, sof, eae+blinkwatch, vivekg, dglazkov+blink, blink-reviews-bindings_chromium.org, Inactive, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

bindings: Remove [EventConstructor] and [InitializedByEventConstructor] We no longer need this. Also remove Dictionary::convert(), which was used in constructors generated by [EventConstructor] BUG=433179 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196369

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -939 lines) Patch
M LayoutTests/fast/events/constructors/event-constructors.html View 2 chunks +2 lines, -3 lines 1 comment Download
M LayoutTests/fast/events/constructors/event-constructors-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M Source/bindings/IDLExtendedAttributes.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/Dictionary.h View 2 chunks +0 lines, -50 lines 0 comments Download
M Source/bindings/core/v8/Dictionary.cpp View 2 chunks +0 lines, -42 lines 0 comments Download
M Source/bindings/core/v8/DictionaryHelperForBindings.h View 1 chunk +0 lines, -20 lines 0 comments Download
M Source/bindings/core/v8/DictionaryHelperForCore.cpp View 7 chunks +0 lines, -138 lines 0 comments Download
M Source/bindings/modules/v8/DictionaryHelperForModules.cpp View 1 chunk +0 lines, -29 lines 0 comments Download
M Source/bindings/scripts/v8_attributes.py View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/bindings/scripts/v8_interface.py View 3 chunks +1 line, -15 lines 0 comments Download
M Source/bindings/templates/interface.cpp View 2 chunks +0 lines, -95 lines 0 comments Download
M Source/bindings/templates/interface_base.cpp View 1 chunk +0 lines, -1 line 0 comments Download
D Source/bindings/tests/idls/core/TestInterfaceEventConstructor.idl View 1 chunk +0 lines, -47 lines 0 comments Download
M Source/bindings/tests/results/core/TestInterfaceEventInit.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/TestInterfaceEventInit.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.h View 1 chunk +0 lines, -58 lines 0 comments Download
D Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp View 1 chunk +0 lines, -392 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceEventInit.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/core.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/Fullscreen.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/Event.h View 4 chunks +1 line, -16 lines 0 comments Download
M Source/core/events/Event.cpp View 2 chunks +0 lines, -11 lines 0 comments Download
M Source/core/events/Event.idl View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/events/EventInit.idl View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
bashi
PTAL? https://codereview.chromium.org/1154943009/diff/1/LayoutTests/fast/events/constructors/event-constructors.html File LayoutTests/fast/events/constructors/event-constructors.html (left): https://codereview.chromium.org/1154943009/diff/1/LayoutTests/fast/events/constructors/event-constructors.html#oldcode54 LayoutTests/fast/events/constructors/event-constructors.html:54: // FIXME: Should this throw? Yes. This should ...
5 years, 6 months ago (2015-06-03 03:40:38 UTC) #2
haraken
LGTM! Finally done!
5 years, 6 months ago (2015-06-03 03:47:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154943009/1
5 years, 6 months ago (2015-06-03 04:14:57 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 05:05:25 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196369

Powered by Google App Engine
This is Rietveld 408576698