Fixing an edge case in CRWBrowsingDataStore

ios/web/public/crw_browsing_data_store.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IOS_WEB_CRW_BROWSING_DATA_STORE_H_
 #define IOS_WEB_CRW_BROWSING_DATA_STORE_H_
 
 #import <Foundation/Foundation.h>
 
 #import "base/ios/block_types.h"
@@ skipping 25 matching lines @@
 
 // Designated initializer. |browserState| cannot be a nullptr.
 // The |web::ActiveStateManager| associated with |browserState| needs to be in
 // active state.
 - (instancetype)initWithBrowserState:(web::BrowserState*)browserState
     NS_DESIGNATED_INITIALIZER;
 
 // Returns a set of all available browsing data types.
 + (NSSet*)allBrowsingDataTypes;
 
-// The mode that the CRWBrowsingDataStore is in.
+// The mode that the CRWBrowsingDataStore is in. KVO compliant.
 @property(nonatomic, assign, readonly) CRWBrowsingDataStoreMode mode;
 
 // TODO(shreyasv): Verify the preconditions for the following 3 methods when
 // web::WebViewCounter class is implemented. crbug.com/480507
 
 // Changes the mode to |ACTIVE|.
-// |completionHandler| is called on the main thread.
+// |completionHandler| is called on the main thread. This block has no return
+// value and takes a single Boolean argument that indicates whether or not the

[Eugene But (OOO till 7-30), 2015/05/29 21:14:26]

NIT: s/Boolean/BOOL, because Boolean is an actual type.

[shreyasv1, 2015/05/29 22:22:57]

well, this is modeled after the comment in 
https://developer.apple.com/library/ios/documentation/UIKit/Reference/UIView_...:

But I don't have a strong preference. Done.

+// the mode was successfully changed to |ACTIVE|.

[Eugene But (OOO till 7-30), 2015/05/29 21:14:26]

Please describe cases where completion handler is actually called with NO

[shreyasv1, 2015/05/29 22:22:57]

Done.

 // Precondition: There must be no web views associated with the BrowserState.
-// Note: If there is another operation driven to change the mode, the mode will
-// still be |SYNCHRONIZING| rather than |ACTIVE| when the callback is received.
-- (void)makeActiveWithCompletionHandler:(ProceduralBlock)completionHandler;
+- (void)makeActiveWithCompletionHandler:
+        (void (^)(BOOL success))completionHandler;
 
 // Changes the mode to |INACTIVE|.
-// |completionHandler| is called on the main thread.
+// |completionHandler| is called on the main thread. This block has no return
+// value and takes a single Boolean argument that indicates whether or not the
+// the mode was successfully changed to |INACTIVE|.

[Eugene But (OOO till 7-30), 2015/05/29 21:14:26]

Same thing, please describe failure case

[shreyasv1, 2015/05/29 22:22:57]

Done.

 // Precondition: There must be no web views associated with the BrowserState.
-// Note: If there is another operation driven to change the mode, the mode will
-// still be |SYNCHRONIZING| rather than |INACTIVE| when the callback is
-// received.
-- (void)makeInactiveWithCompletionHandler:(ProceduralBlock)completionHandler;
+- (void)makeInactiveWithCompletionHandler:
+        (void (^)(BOOL success))completionHandler;
 
 // Removes all browsing data of the provided |browsingDataTypes|.
 // |completionHandler| is called on the main thread after the browsing data has
 // been removed.
 // Precondition: There must be no web views associated with the BrowserState.
 - (void)removeDataOfTypes:(NSSet*)browsingDataTypes
         completionHandler:(ProceduralBlock)completionHandler;
 
 // Returns YES if there is still a pending operation that has not finished
 // running. Creating web views (UIWebViews and WKWebViews) with this
 // CRWBrowsingDataStore when there are pending operations is undefined
 // behavior.
 @property(nonatomic, assign, readonly) BOOL hasPendingOperations;
 
 @end
 
 #endif  // IOS_WEB_CRW_BROWSING_DATA_STORE_H_