Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1154913003: Add some JavaDoc for DOMUtils.java. (Closed)

Created:
5 years, 7 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 6 months ago
Reviewers:
Miguel Garcia
CC:
chromium-reviews, darin-cc_chromium.org, jam, qinmin
Base URL:
https://chromium.googlesource.com/chromium/src.git@media_session
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add some JavaDoc for DOMUtils.java. This is written on top of the changes from: https://codereview.chromium.org/1110833004 BUG=491588 Committed: https://crrev.com/0373e98b1e1e718af055ba74353ed3f4a4c31316 Cr-Commit-Position: refs/heads/master@{#331971}

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove throws #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -35 lines) Patch
M content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java View 1 20 chunks +98 lines, -35 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
mlamouri (slow - plz ping)
5 years, 7 months ago (2015-05-24 17:08:37 UTC) #2
Miguel Garcia
https://codereview.chromium.org/1154913003/diff/1/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java File content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java (right): https://codereview.chromium.org/1154913003/diff/1/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java#newcode29 content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java:29: * @throws TimeoutException there is no point is adding ...
5 years, 7 months ago (2015-05-26 09:30:25 UTC) #3
mlamouri (slow - plz ping)
PTAL. https://codereview.chromium.org/1154913003/diff/1/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java File content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java (right): https://codereview.chromium.org/1154913003/diff/1/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java#newcode29 content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java:29: * @throws TimeoutException On 2015/05/26 at 09:30:25, Miguel ...
5 years, 7 months ago (2015-05-26 14:14:36 UTC) #5
Miguel Garcia
lgtm
5 years, 7 months ago (2015-05-26 15:18:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154913003/40001
5 years, 6 months ago (2015-05-29 14:17:53 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 6 months ago (2015-05-29 15:05:38 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-05-29 15:06:54 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0373e98b1e1e718af055ba74353ed3f4a4c31316
Cr-Commit-Position: refs/heads/master@{#331971}

Powered by Google App Engine
This is Rietveld 408576698