Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(979)

Issue 1154913002: Enable more benchmark_smoke_unittest coverage (Reland) (Closed)

Created:
5 years, 7 months ago by nednguyen
Modified:
5 years, 7 months ago
Reviewers:
sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable more benchmark_smoke_unittest coverage (Reland) Previously, benchmark_smoke_unittest has a heuristic to pick a benchmark for smoke testing if the benchmark uses a test in measurement directory. This patch removes that check, and instead provide a black list of benchmarks module that we exclude the benchmark_smoke_unittest to avoid high CQ time. This helped increases benchmark smoke coverage from 14 benchmarks -> 33 benchmarks (one benchmark per benchmark module). On my local linux machine, this increases the cycle time of benchmark_smoke_unittest from 20s -> 1m7s. To review this, the 1st patch is from issue 1151013002 at patchset 20001 (http://crrev.com/1151013002#ps20001). 2nd patch adds image_decoding to the black list. BUG= CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect Committed: https://crrev.com/cd42fc33c58a58b4067f5c3c578634205c214958 Cr-Commit-Position: refs/heads/master@{#331157}

Patch Set 1 #

Patch Set 2 : Black list image_decoding benchmark #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -12 lines) Patch
M tools/perf/benchmarks/benchmark_smoke_unittest.py View 1 2 chunks +30 lines, -11 lines 0 comments Download
M tools/telemetry/telemetry/user_story/user_story_set.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
nednguyen
5 years, 7 months ago (2015-05-22 15:57:15 UTC) #2
sullivan
lgtm
5 years, 7 months ago (2015-05-22 16:14:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154913002/20001
5 years, 7 months ago (2015-05-22 16:16:15 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-22 19:27:11 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 19:28:03 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cd42fc33c58a58b4067f5c3c578634205c214958
Cr-Commit-Position: refs/heads/master@{#331157}

Powered by Google App Engine
This is Rietveld 408576698