Move generate_perf_events_symbols flag to VM (new issue with @google address)

runtime/bin/main.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include <stdlib.h>
 #include <string.h>
 #include <stdio.h>
 
 #include "include/dart_api.h"
 #include "include/dart_debugger_api.h"
 
 #include "bin/builtin.h"
 #include "bin/dartutils.h"
 #include "bin/dbg_connection.h"
 #include "bin/directory.h"
 #include "bin/eventhandler.h"
 #include "bin/extensions.h"
 #include "bin/file.h"
 #include "bin/isolate_data.h"
 #include "bin/log.h"
 #include "bin/platform.h"
 #include "bin/process.h"
 #include "platform/globals.h"
 
 // snapshot_buffer points to a snapshot if we link in a snapshot otherwise
 // it is initialized to NULL.
 extern const uint8_t* snapshot_buffer;
 
-
-// Global state that indicates whether perf_events symbol information
-// is to be generated or not.
-static File* perf_events_symbols_file = NULL;
-
-
 // Global state that indicates whether pprof symbol information is
 // to be generated or not.
 static const char* generate_pprof_symbols_filename = NULL;
 
 
 // Global state that stores a pointer to the application script snapshot.
 static bool use_script_snapshot = false;
 static File* snapshot_file = NULL;
 
 
@@ skipping 101 matching lines @@
   if (debug_port == 0) {
     Log::PrintErr("unrecognized --debug option syntax. "
                     "Use --debug[:<port number>]\n");
     return false;
   }
   breakpoint_at = "main";
   start_debugger = true;
   return true;
 }
 
-
-static bool ProcessPerfEventsOption(const char* option) {
-  ASSERT(option != NULL);
-  if (perf_events_symbols_file == NULL) {
-    // TODO(cshapiro): eliminate the #ifdef by moving this code to a
-    // Linux specific source file.
-#if defined(TARGET_OS_LINUX)
-    const char* format = "/tmp/perf-%ld.map";
-    intptr_t pid = Process::CurrentProcessId();
-    intptr_t len = snprintf(NULL, 0, format, pid);
-    char* filename = new char[len + 1];
-    snprintf(filename, len + 1, format, pid);
-    perf_events_symbols_file = File::Open(filename, File::kWriteTruncate);
-    ASSERT(perf_events_symbols_file != NULL);
-    delete[] filename;
-#endif
-  }
-  return true;
-}
-
-
 static bool ProcessPprofOption(const char* filename) {
   ASSERT(filename != NULL);
   generate_pprof_symbols_filename = filename;
   return true;
 }
 
 
 static bool ProcessScriptSnapshotOption(const char* filename) {
   if (filename != NULL && strlen(filename) != 0) {
     use_script_snapshot = true;
@@ skipping 12 matching lines @@
   { "--help", ProcessHelpOption },
   { "-h", ProcessHelpOption },
   { "--verbose", ProcessVerboseOption },
   { "-v", ProcessVerboseOption },
   { "--package-root=", ProcessPackageRootOption },
   { "-p", ProcessPackageRootOption },
   // VM specific options to the standalone dart program.
   { "--break_at=", ProcessBreakpointOption },
   { "--compile_all", ProcessCompileAllOption },
   { "--debug", ProcessDebugOption },
-  { "--generate_perf_events_symbols", ProcessPerfEventsOption },
   { "--generate_pprof_symbols=", ProcessPprofOption },
   { "--use_script_snapshot=", ProcessScriptSnapshotOption },
   { NULL, NULL }
 };
 
 
 static bool ProcessMainOptions(const char* option) {
   int i = 0;
   const char* name = main_options[0].option_name;
   while (name != NULL) {
@@ skipping 79 matching lines @@
       const char* kPrintFlags2 = "--print_flags";
       if ((strncmp(argv[i], kPrintFlags1, strlen(kPrintFlags1)) == 0) ||
           (strncmp(argv[i], kPrintFlags2, strlen(kPrintFlags2)) == 0)) {
         *print_flags_seen = true;
       }
       vm_options->AddArgument(argv[i]);
       i++;
     }
   }
 
-  if (perf_events_symbols_file != NULL) {
-    Dart_InitPerfEventsSupport(perf_events_symbols_file);
-  }
-
   if (generate_pprof_symbols_filename != NULL) {
     Dart_InitPprofSupport();
   }
 
   // Get the script name.
   if (i < argc) {
     *script_name = argv[i];
     i++;
   } else {
     return -1;
@@ skipping 466 matching lines @@
   Dart_ShutdownIsolate();
   // Terminate process exit-code handler.
   Process::TerminateExitCodeHandler();
   // Free copied argument strings if converted.
   if (argv_converted) {
     for (int i = 0; i < argc; i++) free(argv[i]);
   }
 
   return 0;
 }