Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1154893003: Change code review host to Chromium's Rietveld. (Closed)

Created:
5 years, 6 months ago by kjellander_chromium
Modified:
5 years, 3 months ago
Reviewers:
fbarchard
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Change code review host to Chromium's Rietveld. Since WebRTC's codereview instance at webrtc-codereview.appspot.com is going to be read-only, libyuv needs to switch to Chromium's instance. Also update the ViewVC URL to match the Git repo that is now the master repo. After this CL has landed, existing Git branches will continue to remember which Rietveld URL they uploaded to. To reset a branch and re-upload a new CL to the new instance, do like this: git cl issue 0 git pull --rebase origin master git cl upload BUG=libyuv:450 R=fbarchard@chromium.org Committed: https://chromium.googlesource.com/libyuv/libyuv/+/3f893126a56e1e922090b7fb20f8f65a340433d0

Patch Set 1 #

Patch Set 2 : Updating Viewvc URL as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M codereview.settings View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
kjellander_chromium
5 years, 6 months ago (2015-06-05 08:35:02 UTC) #2
fbarchard
Any implications?
5 years, 6 months ago (2015-06-05 17:22:42 UTC) #3
kjellander_chromium
On 2015/06/05 17:22:42, fbarchard wrote: > Any implications? Absolutely. See my e-mail for all details.
5 years, 6 months ago (2015-06-06 15:58:19 UTC) #4
fbarchard
lgtm
5 years, 3 months ago (2015-09-05 01:48:54 UTC) #5
kjellander_chromium
Updated the CL description with more details. Will commit this now and send a PSA ...
5 years, 3 months ago (2015-09-06 04:37:14 UTC) #6
kjellander_chromium
5 years, 3 months ago (2015-09-06 04:49:07 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3f893126a56e1e922090b7fb20f8f65a340433d0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698