Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(135)

Issue 1154883006: Fix fast/dom/shadow/tab-order-iframe-and-shadow.html to finish properly (Closed)

Created:
4 years, 11 months ago by kochi
Modified:
4 years, 11 months ago
Reviewers:
hayato
CC:
blink-reviews
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Fix fast/dom/shadow/tab-order-iframe-and-shadow.html to finish properly The test has misused log() where debug() should be used. The test itself has been okay, only the finshed message had this problem. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196475

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M LayoutTests/fast/dom/shadow/tab-order-iframe-and-shadow.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/tab-order-iframe-and-shadow-expected.txt View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
kochi
PTAL
4 years, 11 months ago (2015-06-04 05:15:32 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154883006/1
4 years, 11 months ago (2015-06-04 05:15:53 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2015-06-04 06:20:49 UTC) #6
hayato
lgtm
4 years, 11 months ago (2015-06-04 07:33:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154883006/1
4 years, 11 months ago (2015-06-04 07:35:00 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2015-06-04 07:39:01 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196475

Powered by Google App Engine
This is Rietveld 408576698