IndexedDB: Rethrow exceptions thrown by getters during keypath eval

IndexedDB: Rethrow exceptions thrown by getters during keypath eval

BUG=493860
R=cmumford@chromium.org,haraken@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196355

[jsbell, 2015-06-02 00:02:34]

cmumford@, haraken@ - please take a look?

[haraken, 2015-06-02 00:42:56]

LGTM

[cmumford, 2015-06-02 19:12:28]

lgtm

https://codereview.chromium.org/1154873007/diff/30001/Source/bindings/modules...
File Source/bindings/modules/v8/V8BindingForModules.cpp (right):

https://codereview.chromium.org/1154873007/diff/30001/Source/bindings/modules...
Source/bindings/modules/v8/V8BindingForModules.cpp:295: v8::Local<v8::Context>
context = isolate->GetCurrentContext();
Can you move context = outside of the for loop?

[jsbell, 2015-06-02 19:15:35]

https://codereview.chromium.org/1154873007/diff/30001/Source/bindings/modules...
File Source/bindings/modules/v8/V8BindingForModules.cpp (right):

https://codereview.chromium.org/1154873007/diff/30001/Source/bindings/modules...
Source/bindings/modules/v8/V8BindingForModules.cpp:295: v8::Local<v8::Context>
context = isolate->GetCurrentContext();
On 2015/06/02 19:12:28, cmumford wrote:
> Can you move context = outside of the for loop?

Done.

[jsbell, 2015-06-02 19:16:07]

The CQ bit was checked by jsbell@chromium.org

[jsbell, 2015-06-02 19:16:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, cmumford@chromium.org
Link to the patchset: https://codereview.chromium.org/1154873007/#ps70001
(title: "Move context out of loop")

[commit-bot: I haz the power, 2015-06-02 19:17:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1154873007/70001

[commit-bot: I haz the power, 2015-06-02 19:30:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-02 19:30:19]

Try jobs failed on following builders:
  win_blink_compile_dbg on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/bu...)

[jsbell, 2015-06-02 19:32:20]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2015-06-02 19:33:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1154873007/70001

[commit-bot: I haz the power, 2015-06-02 20:29:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-02 20:29:23]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/6...)

[jsbell, 2015-06-02 22:32:31]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2015-06-02 22:34:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1154873007/70001

[commit-bot: I haz the power, 2015-06-02 23:18:34]

Committed patchset #5 (id:70001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196355