Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 1154873002: [turbofan] Simplify handling of spreads in array literals. (Closed)

Created:
5 years, 7 months ago by Michael Starzinger
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_graph-builder-computed-property-names-deopt
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Simplify handling of spreads in array literals. R=arv@chromium.org TEST=mjsunit/harmony/spread-array Committed: https://crrev.com/4e6ed6b31f1c8568f2d451435c77f5f1308e1971 Cr-Commit-Position: refs/heads/master@{#28598}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M src/compiler/ast-graph-builder.cc View 2 chunks +2 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 7 months ago (2015-05-22 14:24:22 UTC) #1
arv (Not doing code reviews)
LGTM Doh.
5 years, 7 months ago (2015-05-22 15:04:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154873002/1
5 years, 7 months ago (2015-05-22 15:41:21 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-22 15:43:05 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 15:43:23 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4e6ed6b31f1c8568f2d451435c77f5f1308e1971
Cr-Commit-Position: refs/heads/master@{#28598}

Powered by Google App Engine
This is Rietveld 408576698