Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: Source/core/svg/SVGUseElement.cpp

Issue 1154853007: Move toClipPath to SVGGeometryElement. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Draft 14 Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGUseElement.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGUseElement.cpp
diff --git a/Source/core/svg/SVGUseElement.cpp b/Source/core/svg/SVGUseElement.cpp
index e56f7c78d65ffa83f4748ca4b87916614e959905..288b62ad7af4181459b09a011582f896135846db 100644
--- a/Source/core/svg/SVGUseElement.cpp
+++ b/Source/core/svg/SVGUseElement.cpp
@@ -440,37 +440,46 @@ static bool isDirectReference(const SVGElement& element)
|| isSVGTextElement(element);
}
-void SVGUseElement::toClipPath(Path& path)
+void SVGUseElement::toClipPath(Path& path) const
{
ASSERT(path.isEmpty());
- Node* n = userAgentShadowRoot()->firstChild();
- if (!n || !n->isSVGElement())
+ const SVGGraphicsElement* element = targetGraphicsElementForClipping();
+
+ if (!element)
return;
- SVGElement& element = toSVGElement(*n);
- if (element.isSVGGraphicsElement()) {
- if (!isDirectReference(element)) {
- // Spec: Indirect references are an error (14.3.5)
- document().accessSVGExtensions().reportError("Not allowed to use indirect reference in <clip-path>");
- } else {
- toSVGGraphicsElement(element).toClipPath(path);
- // FIXME: Avoid manual resolution of x/y here. Its potentially harmful.
- SVGLengthContext lengthContext(this);
- path.translate(FloatSize(m_x->currentValue()->value(lengthContext), m_y->currentValue()->value(lengthContext)));
- path.transform(calculateAnimatedLocalTransform());
- }
+ if (element->isSVGGeometryElement()) {
+ toSVGGeometryElement(*element).toClipPath(path);
+ // FIXME: Avoid manual resolution of x/y here. Its potentially harmful.
+ SVGLengthContext lengthContext(this);
+ path.translate(FloatSize(m_x->currentValue()->value(lengthContext), m_y->currentValue()->value(lengthContext)));
+ path.transform(calculateAnimatedLocalTransform());
}
}
-LayoutObject* SVGUseElement::layoutObjectClipChild() const
+SVGGraphicsElement* SVGUseElement::targetGraphicsElementForClipping() const
{
- if (Node* n = userAgentShadowRoot()->firstChild()) {
- if (n->isSVGElement() && isDirectReference(toSVGElement(*n)))
- return n->layoutObject();
+ Node* n = userAgentShadowRoot()->firstChild();
+ if (!n || !n->isSVGElement())
+ return nullptr;
+
+ SVGElement& element = toSVGElement(*n);
+
+ if (!element.isSVGGraphicsElement())
+ return nullptr;
+
+ // Spec: "If a <use> element is a child of a clipPath element, it must directly
+ // reference <path>, <text> or basic shapes elements. Indirect references are an
+ // error and the clipPath element must be ignored."
+ // http://dev.w3.org/fxtf/css-masking-1/#the-clip-path
+ if (!isDirectReference(element)) {
+ // Spec: Indirect references are an error (14.3.5)
+ document().accessSVGExtensions().reportError("Not allowed to use indirect reference in <clip-path>");
+ return nullptr;
}
- return nullptr;
+ return &toSVGGraphicsElement(element);
}
bool SVGUseElement::buildShadowTree(SVGElement* target, SVGElement* targetInstance, bool foundUse)
« no previous file with comments | « Source/core/svg/SVGUseElement.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698