Source/core/svg/SVGGraphicsElement.h - Issue 1154853007: Move toClipPath to SVGGeometryElement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGGraphicsElement.h

Issue 1154853007: Move toClipPath to SVGGeometryElement. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Draft 1 Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/SVGGraphicsElement.h

diff --git a/Source/core/svg/SVGGraphicsElement.h b/Source/core/svg/SVGGraphicsElement.h

index 17451acc98dcfc059fefa82b6632d6713d001f59..b407523a312bee43327b27b21801f6da331c98cb 100644

--- a/Source/core/svg/SVGGraphicsElement.h

+++ b/Source/core/svg/SVGGraphicsElement.h

@@ -60,9 +60,6 @@ public:

virtual FloatRect getBBox();

PassRefPtrWillBeRawPtr<SVGRectTearOff> getBBoxFromJavascript();

- // FIXME: This should only be defined on SVGGeometryElement.

- virtual void toClipPath(Path&) { }

virtual bool isValid() const override final { return SVGTests::isValid(document()); }

SVGAnimatedTransformList* transform() { return m_transform.get(); }