Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1154833002: [test] Fix no-exceptions cc flag. (Closed)

Created:
5 years, 7 months ago by Michael Achenbach
Modified:
5 years, 7 months ago
CC:
Alexander Potapenko, v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Fix no-exceptions cc flag. BUG=chromium:425187 LOG=n Committed: https://crrev.com/17d2f3b13bd4e6e3a1c2f9c209b40fb45ed3b9e6 Cr-Commit-Position: refs/heads/master@{#28599}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M build/standalone.gypi View 1 3 chunks +12 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Michael Achenbach
PTAL
5 years, 7 months ago (2015-05-22 13:13:59 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-05-22 13:15:36 UTC) #3
Michael Achenbach
I assume the msan bot has some unrelated problem. It is new and not trustworthy ...
5 years, 7 months ago (2015-05-22 13:41:24 UTC) #4
earthdok
On 2015/05/22 13:41:24, Michael Achenbach wrote: > I assume the msan bot has some unrelated ...
5 years, 7 months ago (2015-05-22 14:52:29 UTC) #5
Michael Achenbach
Thanks. I couldn't repro locally. I'll land this CL as the trybot seems generally broken. ...
5 years, 7 months ago (2015-05-22 16:38:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154833002/20001
5 years, 7 months ago (2015-05-22 16:38:43 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-22 16:40:34 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 16:40:54 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/17d2f3b13bd4e6e3a1c2f9c209b40fb45ed3b9e6
Cr-Commit-Position: refs/heads/master@{#28599}

Powered by Google App Engine
This is Rietveld 408576698