DescriptionMerge 137275
> INPUT_MULTIPLE_FIELDS_UI: Disable focus navigation by right/left keys in RTL locales
> https://bugs.webkit.org/show_bug.cgi?id=104644
>
> Reviewed by Hajime Morita.
>
> Source/WebCore:
>
> Pressing the left key should focus on the field at the left of the
> current focused field, and pressing the right key should focus on the
> field at the right of the current focused field. This works well in LTR
> locales.
> In RTL locale, the current code doesn't work. We disable this behavior
> for RTL locales for now. This issue will be handled in Bug 104650.
>
> No new tests. Update some *-multiple-fields tests for new behavior.
>
> * html/shadow/DateTimeFieldElement.cpp:
> (WebCore::DateTimeFieldElement::defaultKeyboardEventHandler):
> If this sub-field is in an RTL locale, we don't change focus.
> (WebCore::DateTimeFieldElement::localeForOwner):
> Moved from DateTimeNumericFieldElement.
> * html/shadow/DateTimeFieldElement.h:
> (DateTimeFieldElement): Remove isRTL, add localeForOwner.
> * html/shadow/DateTimeNumericFieldElement.cpp: Remove localeForOwner.
> * html/shadow/DateTimeNumericFieldElement.h:
> (DateTimeNumericFieldElement): Ditto.
>
> LayoutTests:
>
> * fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt:
> * fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events.html:
> * fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events-expected.txt:
> * fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events.html:
> * fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events-expected.txt:
> * fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events.html:
> * fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt:
> * fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html:
>
TBR=tkent@chromium.org
BUG=crbug.com/163108
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137546
Patch Set 1 #
Messages
Total messages: 1 (0 generated)
|