Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 11548051: Merge 137275 (Closed)

Created:
8 years ago by tkent
Modified:
8 years ago
Reviewers:
tkent
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1312/
Visibility:
Public.

Description

Merge 137275 > INPUT_MULTIPLE_FIELDS_UI: Disable focus navigation by right/left keys in RTL locales > https://bugs.webkit.org/show_bug.cgi?id=104644 > > Reviewed by Hajime Morita. > > Source/WebCore: > > Pressing the left key should focus on the field at the left of the > current focused field, and pressing the right key should focus on the > field at the right of the current focused field. This works well in LTR > locales. > In RTL locale, the current code doesn't work. We disable this behavior > for RTL locales for now. This issue will be handled in Bug 104650. > > No new tests. Update some *-multiple-fields tests for new behavior. > > * html/shadow/DateTimeFieldElement.cpp: > (WebCore::DateTimeFieldElement::defaultKeyboardEventHandler): > If this sub-field is in an RTL locale, we don't change focus. > (WebCore::DateTimeFieldElement::localeForOwner): > Moved from DateTimeNumericFieldElement. > * html/shadow/DateTimeFieldElement.h: > (DateTimeFieldElement): Remove isRTL, add localeForOwner. > * html/shadow/DateTimeNumericFieldElement.cpp: Remove localeForOwner. > * html/shadow/DateTimeNumericFieldElement.h: > (DateTimeNumericFieldElement): Ditto. > > LayoutTests: > > * fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt: > * fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events.html: > * fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events-expected.txt: > * fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events.html: > * fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events-expected.txt: > * fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events.html: > * fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt: > * fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html: > TBR=tkent@chromium.org BUG=crbug.com/163108 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137546

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M Source/WebCore/html/shadow/DateTimeFieldElement.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/WebCore/html/shadow/DateTimeFieldElement.cpp View 4 chunks +9 lines, -4 lines 0 comments Download
M Source/WebCore/html/shadow/DateTimeNumericFieldElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/html/shadow/DateTimeNumericFieldElement.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
tkent
8 years ago (2012-12-13 01:31:38 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698