Telemetry / Devtools TraceHandler: exposes tracing via dev tools.

content/browser/debugger/devtools_trace_domain_handler.h

Index: content/browser/debugger/devtools_trace_domain_handler.h
diff --git a/content/browser/debugger/devtools_trace_domain_handler.h b/content/browser/debugger/devtools_trace_domain_handler.h
new file mode 100644
index 0000000000000000000000000000000000000000..45e4c2a5178f19d09b2740bf762441339f537c5d
--- /dev/null
+++ b/content/browser/debugger/devtools_trace_domain_handler.h
@@ -0,0 +1,48 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_DEBUGGER_DEVTOOLS_TRACE_HANDLER_H_
+#define CONTENT_BROWSER_DEBUGGER_DEVTOOLS_TRACE_HANDLER_H_
+
+#include "content/public/browser/trace_subscriber.h"
+#include "content/browser/debugger/devtools_browser_target.h"
+
+namespace content {
+
+// This class bridges DevTools remote debugging server with the trace
+// infrastructure.
+class DevToolsTraceDomainHandler
+    : public TraceSubscriber,
+      public DevToolsBrowserTarget::Handler {
+ public:
+  DevToolsTraceDomainHandler();
+  ~DevToolsTraceDomainHandler();
+
+  // TraceSubscriber:
+  virtual void OnEndTracingComplete();
+  virtual void OnTraceDataCollected(
+      const scoped_refptr<base::RefCountedString>& trace_fragment);
+
+  // DevToolBrowserTarget::Handler:
+  virtual bool OnWebSocketMessage(int connection_id,
+                                  const std::string& data,
+                                  DevToolsServerSender* sender) OVERRIDE;
+
+ private:
+  void BeginTracing(const std::string& categories);
+  void EndTracingAsync();
+  bool has_completed() const;
+
+  std::string GetAndResetTrace();

[pfeldman, 2012/12/12 20:17:12]

I'd create a method per protocol method with the signatures accepting parameters
dict and returning the resulting value and/or error.

[bulach, 2012/12/13 17:36:23]

Done.

+
+  bool has_completed_;
+
+  std::string buffer_;
+
+  DISALLOW_COPY_AND_ASSIGN(DevToolsTraceDomainHandler);
+};
+
+}  // namespace content
+
+#endif  // CONTENT_BROWSER_DEBUGGER_DEVTOOLS_TRACE_HANDLER_H_