Use element.createShadowRoot since WebKitShadowRoot is deprecated.

chrome/renderer/resources/extensions/searchbox_api.js

Index: chrome/renderer/resources/extensions/searchbox_api.js
diff --git a/chrome/renderer/resources/extensions/searchbox_api.js b/chrome/renderer/resources/extensions/searchbox_api.js
index 72925b8ba1eb6dea7504b0b93043e76e3b8058fa..776ef8c950631327672cece90791d80abd51dfc7 100644
--- a/chrome/renderer/resources/extensions/searchbox_api.js
+++ b/chrome/renderer/resources/extensions/searchbox_api.js
@@ -11,7 +11,6 @@ if (!chrome.searchBox) {
     chrome.searchBoxOnWindowReady = function() {
       // |searchBoxOnWindowReady| is used for initializing window context and
       // should be called only once per context.
-      safeObjects.ShadowRoot = window.WebKitShadowRoot;
       safeObjects.defineProperty = Object.defineProperty;
       delete window.chrome.searchBoxOnWindowReady;
     };
@@ -58,7 +57,7 @@ if (!chrome.searchBox) {
     // Returns the |restrictedText| wrapped in a ShadowDOM.
     function SafeWrap(restrictedText) {
       var node = document.createElement('div');
-      var nodeShadow = new safeObjects.ShadowRoot(node);
+      var nodeShadow = node.webkitCreateShadowRoot();

[dglazkov, 2012/12/12 15:22:14]

This is no longer "safe" though. May need extra work to keep it safe.

[hayato, 2012/12/13 01:09:20]

Yeah, I have no idea about the usage of *safe* object here. Difficult to
understand the intention of the safe object. Maybe I am lacking the context.

Can anyone give me an advise?

On 2012/12/12 15:22:14, Dimitri Glazkov wrote:

[David Black, 2012/12/13 04:31:08]

Above in the searchBoxOnWindowReady function, store
Element.prototype.webkitCreateShadowRoot
into the safeObjects object, and then here apply it from safeObjects instead of
calling it off of node directly.
(We're trying to protect against another script on the page overriding
Element.prototype.webkitCreateShadowRoot in between the calling of
searchBoxOnWindowReady and here.)

Thanks for updating our code, by the way!

On 2012/12/13 01:09:20, hayato wrote:

       nodeShadow.applyAuthorStyles = true;
       nodeShadow.innerHTML =
           '<div style="width:700px!important;' +
@@ -68,7 +67,6 @@ if (!chrome.searchBox) {
           '            text-overflow:ellipsis!important">' +
           '  <nobr>' + restrictedText + '</nobr>' +
           '</div>';
-      safeObjects.defineProperty(node, 'webkitShadowRoot', { value: null });
       return node;
     }