Use element.createShadowRoot since WebKitShadowRoot is deprecated.

chrome/renderer/resources/extensions/searchbox_api.js

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var chrome;
 if (!chrome)
   chrome = {};
 if (!chrome.searchBox) {
   chrome.searchBox = new function() {
     var safeObjects = {};
     chrome.searchBoxOnWindowReady = function() {
       // |searchBoxOnWindowReady| is used for initializing window context and
       // should be called only once per context.
-      safeObjects.ShadowRoot = window.WebKitShadowRoot;
       safeObjects.defineProperty = Object.defineProperty;
       delete window.chrome.searchBoxOnWindowReady;
     };
 
     // =========================================================================
     //                                  Constants
     // =========================================================================
     var MAX_CLIENT_SUGGESTIONS_TO_DEDUPE = 6;
     var MAX_ALLOWED_DEDUPE_ATTEMPTS = 5;
 
@@ skipping 26 matching lines @@
     native function SetQuerySuggestionFromAutocompleteResult();
     native function SetQuery();
     native function SetQueryFromAutocompleteResult();
     native function Show();
     native function StartCapturingKeyStrokes();
     native function StopCapturingKeyStrokes();
 
     // Returns the |restrictedText| wrapped in a ShadowDOM.
     function SafeWrap(restrictedText) {
       var node = document.createElement('div');
-      var nodeShadow = new safeObjects.ShadowRoot(node);
+      var nodeShadow = node.webkitCreateShadowRoot();

[dglazkov, 2012/12/12 15:22:14]

This is no longer "safe" though. May need extra work to keep it safe.

[hayato, 2012/12/13 01:09:20]

Yeah, I have no idea about the usage of *safe* object here. Difficult to
understand the intention of the safe object. Maybe I am lacking the context.

Can anyone give me an advise?

On 2012/12/12 15:22:14, Dimitri Glazkov wrote:

[David Black, 2012/12/13 04:31:08]

Above in the searchBoxOnWindowReady function, store
Element.prototype.webkitCreateShadowRoot
into the safeObjects object, and then here apply it from safeObjects instead of
calling it off of node directly.
(We're trying to protect against another script on the page overriding
Element.prototype.webkitCreateShadowRoot in between the calling of
searchBoxOnWindowReady and here.)

Thanks for updating our code, by the way!

On 2012/12/13 01:09:20, hayato wrote:

       nodeShadow.applyAuthorStyles = true;
       nodeShadow.innerHTML =
           '<div style="width:700px!important;' +
           '            height:22px!important;' +
           '            font-family:\'' + GetFont() + '\',\'Arial\'!important;' +
           '            overflow:hidden!important;' +
           '            text-overflow:ellipsis!important">' +
           '  <nobr>' + restrictedText + '</nobr>' +
           '</div>';
-      safeObjects.defineProperty(node, 'webkitShadowRoot', { value: null });
       return node;
     }
 
     // Wraps the AutocompleteResult query and URL into ShadowDOM nodes so that
     // the JS cannot access them and deletes the raw values.
     function GetAutocompleteResultsWrapper() {
       var autocompleteResults = DedupeAutocompleteResults(
           GetAutocompleteResults());
       var userInput = GetQuery();
       for (var i = 0, result; result = autocompleteResults[i]; ++i) {
@@ skipping 150 matching lines @@
     this.onchange = null;
     this.onsubmit = null;
     this.oncancel = null;
     this.onresize = null;
     this.onautocompleteresults = null;
     this.onkeypress = null;
     this.onkeycapturechange = null;
     this.oncontextchange = null;
   };
 }