Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(154)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1154773008: testharnessreport: Remove Text children of the body. (Closed)

Created:
4 years, 10 months ago by tkent
Modified:
4 years, 10 months ago
Reviewers:
dpranke, jsbell
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

testharnessreport: Remove Text children of the body. - Expectations for SVG tests contain \r. Ask the rebaseline bot to update them because we can't patch them. - Other tests in TestExpectations have platform-specific results. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196727

Patch Set 1 : #

Patch Set 2 : update form-validation-reportValidity-expected.txt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -169 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +9 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/media/media-source/mediasource-config-change-mp4-a-bitrate-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/media/media-source/mediasource-config-change-mp4-av-audio-bitrate-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/media/media-source/mediasource-config-change-mp4-av-framesize-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/media/media-source/mediasource-config-change-mp4-av-video-bitrate-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/media/media-source/mediasource-config-change-mp4-v-bitrate-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/media/media-source/mediasource-config-change-mp4-v-framerate-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/media/media-source/mediasource-config-change-mp4-v-framesize-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/resources/testharnessreport.js View 1 chunk +7 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/w3c/resources/testharnessreport.js View 1 chunk +7 lines, -2 lines 0 comments Download
D LayoutTests/http/tests/w3c/webperf/approved/UserTiming/test_user_timing_clear_marks-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/http/tests/w3c/webperf/approved/UserTiming/test_user_timing_clear_measures-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/http/tests/w3c/webperf/approved/UserTiming/test_user_timing_mark-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/http/tests/w3c/webperf/approved/UserTiming/test_user_timing_measure-expected.txt View 1 chunk +0 lines, -35 lines 0 comments Download
M LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_xserver_redirect-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/browsers/the-window-object/window-indexed-properties-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/browsers/the-window-object/window-indexed-properties-strict-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/browsers/the-window-object/window-named-properties-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/browsers/windows/browsing-context-first-created-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/browsers/windows/nested-browsing-contexts/frameElement.sub-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/imported/web-platform-tests/html/dom/dynamic-markup-insertion/document-write/051-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M LayoutTests/imported/web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/001-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/005-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/008-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/editing/focus/focus-management/focus-events-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/infrastructure/common-dom-interfaces/collections/htmlallcollection-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/infrastructure/common-dom-interfaces/collections/htmloptionscollection-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/obsolete/requirements-for-implementations/the-marquee-element-0/marquee-scrolldelay-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrackCueList/getter-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-in-sync-event-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-control-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-insert-br-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-insert-source-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-insert-text-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-remove-source-after-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-remove-source-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-remove-text-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-source-media-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/embedded-content/the-img-element/current-pixel-density/basic-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/embedded-content/the-img-element/img.complete-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/forms/constraints/form-validation-checkValidity-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/forms/constraints/form-validation-reportValidity-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-badInput-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeOverflow-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeUnderflow-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-stepMismatch-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-tooLong-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-tooShort-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valid-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valueMissing-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/forms/textfieldselection/select-event-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/forms/textfieldselection/selection-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/forms/the-button-element/button-validation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/forms/the-datalist-element/datalistoptions-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/forms/the-input-element/checkbox-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/forms/the-input-element/radio-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/forms/the-input-element/radio-groupname-case-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/forms/the-label-element/label-attributes-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/forms/the-select-element/common-HTMLOptionsCollection-namedItem-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/grouping-content/the-li-element/grouping-li-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-showModal-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/selectors/pseudo-classes/checked-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/selectors/pseudo-classes/default-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/selectors/pseudo-classes/dir-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/selectors/pseudo-classes/disabled-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/selectors/pseudo-classes/enabled-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/selectors/pseudo-classes/focus-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/selectors/pseudo-classes/indeterminate-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/selectors/pseudo-classes/inrange-outofrange-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/selectors/pseudo-classes/link-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/TextTrackCueList/getter-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/VTTCue/getCueAsHTML-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/VTTCue/snapToLines-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/android/imported/web-platform-tests/html/semantics/forms/constraints/form-validation-reportValidity-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/imported/web-platform-tests/html/semantics/forms/constraints/form-validation-reportValidity-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/imported/web-platform-tests/html/semantics/forms/constraints/form-validation-reportValidity-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/resources/testharnessreport.js View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
tkent
Please review this. I'm not if we may remove elements too instead of hiding them.
4 years, 10 months ago (2015-06-08 23:52:48 UTC) #4
jsbell
lgtm
4 years, 10 months ago (2015-06-09 00:03:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154773008/60001
4 years, 10 months ago (2015-06-09 01:12:22 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2015-06-09 03:01:39 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196727

Powered by Google App Engine
This is Rietveld 408576698