Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 1154773007: Remove memcmp from GrProgramDesc op== and Less (Closed)

Created:
5 years, 6 months ago by bsalomon
Modified:
5 years, 6 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove memcmp from GrProgramDesc op== and Less Works around an ASAN complaint. BUG=skia:3891 Committed: https://skia.googlesource.com/skia/+/89d59883f39d4097183e632b86da439052499527

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix assert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -4 lines) Patch
M src/gpu/GrProgramDesc.h View 1 2 chunks +21 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
bsalomon
5 years, 6 months ago (2015-06-04 22:10:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154773007/1
5 years, 6 months ago (2015-06-04 22:11:00 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 6 months ago (2015-06-04 22:11:02 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/1396)
5 years, 6 months ago (2015-06-04 22:12:15 UTC) #7
robertphillips
lgtm % '.' https://codereview.chromium.org/1154773007/diff/1/src/gpu/GrProgramDesc.h File src/gpu/GrProgramDesc.h (right): https://codereview.chromium.org/1154773007/diff/1/src/gpu/GrProgramDesc.h#newcode42 src/gpu/GrProgramDesc.h:42: bool operator== (const GrProgramDesc& that) const ...
5 years, 6 months ago (2015-06-04 22:15:50 UTC) #8
bsalomon
https://codereview.chromium.org/1154773007/diff/1/src/gpu/GrProgramDesc.h File src/gpu/GrProgramDesc.h (right): https://codereview.chromium.org/1154773007/diff/1/src/gpu/GrProgramDesc.h#newcode42 src/gpu/GrProgramDesc.h:42: bool operator== (const GrProgramDesc& that) const { On 2015/06/04 ...
5 years, 6 months ago (2015-06-04 22:16:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154773007/20001
5 years, 6 months ago (2015-06-04 22:16:46 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-04 22:34:47 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/89d59883f39d4097183e632b86da439052499527

Powered by Google App Engine
This is Rietveld 408576698