Fix DCHECK on SetBookmark.

Fix DCHECK on SetBookmark.

The DCHECK was a lie. The idea was that - when a bookmark is set -
the scanner must clearly be at a character boundary and hence the
bookmark does not need to save a 'partial' UTF-8 code point. The
first part is true - the Scanner is always at a character boundary -
but the 'partial' UTF-8 code point is at the end of a block, not at
the current character position of the Scanner.
Hence, the 'partial' character needs to be saved as well.

jkummerow: Thanks for noticing.

BUG=chromium:470930
R=jochen@chromium.org, jkummerow@chromium.org
LOG=N

Committed: https://crrev.com/21e6831ee0526449affa3ef9232e8890fa2617ad
Cr-Commit-Position: refs/heads/master@{#28661}

[Jakob Kummerow, 2015-05-27 15:10:40]

Thanks for fixing! I have a nit. (Haven't reviewed for correctness, just
skimmed.)

https://codereview.chromium.org/1154773004/diff/1/src/scanner-character-strea...
File src/scanner-character-streams.cc (right):

https://codereview.chromium.org/1154773004/diff/1/src/scanner-character-strea...
src/scanner-character-streams.cc:424: bookmark_utf8_split_char_buffer_[i] =
utf8_split_char_buffer_[i];
nit: V8 wants {} (unless header and body fit on the same line). Again below.

[jochen (gone - plz use gerrit), 2015-05-27 15:14:58]

lgtm

[vogelheim, 2015-05-27 15:17:55]

https://codereview.chromium.org/1154773004/diff/1/src/scanner-character-strea...
File src/scanner-character-streams.cc (right):

https://codereview.chromium.org/1154773004/diff/1/src/scanner-character-strea...
src/scanner-character-streams.cc:424: bookmark_utf8_split_char_buffer_[i] =
utf8_split_char_buffer_[i];
On 2015/05/27 15:10:40, Jakob wrote:
> nit: V8 wants {} (unless header and body fit on the same line). Again below.

Done.

[vogelheim, 2015-05-27 15:27:48]

The CQ bit was checked by vogelheim@chromium.org

[vogelheim, 2015-05-27 15:27:48]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1154773004/#ps20001
(title: "De-nit-ification.")

[commit-bot: I haz the power, 2015-05-27 15:27:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1154773004/20001

[commit-bot: I haz the power, 2015-05-27 15:43:35]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-27 15:43:51]

Patchset 2 (id:??) landed as
https://crrev.com/21e6831ee0526449affa3ef9232e8890fa2617ad
Cr-Commit-Position: refs/heads/master@{#28661}