Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(114)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1154753006: Remove CSSRule.UNKNOWN_RULE and CSSUnknownRule interface (Closed)

Created:
4 years, 11 months ago by Sunil Ratnu
Modified:
4 years, 10 months ago
Reviewers:
philipj_slow, pals
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove CSSRule.UNKNOWN_RULE and CSSUnknownRule interface The CSSUnknownRule interface was introduced in DOM Level 2 Style, but has been removed in CSSOM: http://www.w3.org/TR/DOM-Level-2-Style/css.html#CSS-CSSUnknownRule http://dev.w3.org/csswg/cssom/ This patch removes it completely. The link to Intent to Deprecate and Remove is here: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/zzeNGPP1DcA BUG=496383 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196877

Patch Set 1 #

Patch Set 2 : Added CSSRule.UNKNOWN_RULE as well #

Total comments: 4

Patch Set 3 : addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -106 lines) Patch
M LayoutTests/fast/dom/constants.html View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/constants-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/platform/android/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 chunks +0 lines, -3 lines 0 comments Download
M LayoutTests/platform/android/webexposed/global-interface-listing-expected.txt View 1 2 chunks +0 lines, -3 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 chunks +0 lines, -3 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/core.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSRule.h View 1 2 1 chunk +8 lines, -12 lines 0 comments Download
M Source/core/css/CSSRule.idl View 1 1 chunk +0 lines, -2 lines 0 comments Download
D Source/core/css/CSSUnknownRule.h View 1 chunk +0 lines, -45 lines 0 comments Download
D Source/core/css/CSSUnknownRule.idl View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Sunil Ratnu
Please have a look.
4 years, 10 months ago (2015-06-10 10:50:15 UTC) #2
philipj_slow
LGTM % CSSRule.h cleanup https://codereview.chromium.org/1154753006/diff/20001/Source/core/css/CSSRule.h File Source/core/css/CSSRule.h (right): https://codereview.chromium.org/1154753006/diff/20001/Source/core/css/CSSRule.h#newcode44 Source/core/css/CSSRule.h:44: STYLE_RULE = 1, Can you ...
4 years, 10 months ago (2015-06-10 13:34:21 UTC) #3
Sunil Ratnu
Thanks for the review Philip. Made the changes. Please give it a look one more ...
4 years, 10 months ago (2015-06-10 13:54:40 UTC) #4
philipj_slow
lgtm Looks great!
4 years, 10 months ago (2015-06-10 13:59:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154753006/40001
4 years, 10 months ago (2015-06-10 13:59:57 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2015-06-10 15:24:46 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196877

Powered by Google App Engine
This is Rietveld 408576698