Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1563)

Unified Diff: pkg/compiler/lib/src/resolution/send_resolver.dart

Issue 1154743004: Test (and fix some) invalid assignments. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/resolution/send_resolver.dart
diff --git a/pkg/compiler/lib/src/resolution/send_resolver.dart b/pkg/compiler/lib/src/resolution/send_resolver.dart
index 77e35827ceb1f87252eb1e1ca789da3b51221940..9bde72bf74f50056c2385dd1d5bfb18db3e97e46 100644
--- a/pkg/compiler/lib/src/resolution/send_resolver.dart
+++ b/pkg/compiler/lib/src/resolution/send_resolver.dart
@@ -106,10 +106,16 @@ abstract class SendResolverMixin {
}
return new StaticAccess.unresolved(element);
} else if (element.isParameter) {
- return new StaticAccess.parameter(element);
+ if (element.isFinal) {
+ return new StaticAccess.finalParameter(element);
+ } else {
+ return new StaticAccess.parameter(element);
+ }
} else if (element.isLocal) {
if (element.isFunction) {
return new StaticAccess.localFunction(element);
+ } else if (element.isFinal || element.isConst) {
+ return new StaticAccess.finalLocalVariable(element);
} else {
return new StaticAccess.localVariable(element);
}
@@ -424,6 +430,7 @@ abstract class SendResolverMixin {
bool isCompound: false}) {
Element element = elements[node];
Element getter = isCompound ? elements[node.selector] : null;
+ //print('$node,element=$element,getter=$getter');
karlklose 2015/05/22 12:14:19 Remove debug code.
if (elements.isTypeLiteral(node)) {
DartType dartType = elements.getTypeLiteralType(node);
// TODO(johnniwinther): Handle deferred constants. There are runtime

Powered by Google App Engine
This is Rietveld 408576698