Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Unified Diff: src/harmony-typedarray.js

Issue 1154743003: Revert of Hook up more import/exports in natives. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/harmony-tostring.js ('k') | src/i18n.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/harmony-typedarray.js
diff --git a/src/harmony-typedarray.js b/src/harmony-typedarray.js
index 88048b44c9e854cb5d57856b8abf86a4a3694a97..c3cf8e9e308d2c2d716724641f7cd964bfc6f783 100644
--- a/src/harmony-typedarray.js
+++ b/src/harmony-typedarray.js
@@ -7,9 +7,6 @@
"use strict";
%CheckIsBootstrapping();
-
-// -------------------------------------------------------------------
-// Imports
macro TYPED_ARRAYS(FUNCTION)
// arrayIds below should be synchronized with Runtime_TypedArrayInitialize.
@@ -31,40 +28,6 @@
TYPED_ARRAYS(DECLARE_GLOBALS)
DECLARE_GLOBALS(Array)
-var ArrayFrom;
-var InnerArrayCopyWithin;
-var InnerArrayEvery;
-var InnerArrayFill;
-var InnerArrayFilter;
-var InnerArrayFind;
-var InnerArrayFindIndex;
-var InnerArrayForEach;
-var InnerArrayIndexOf;
-var InnerArrayLastIndexOf;
-var InnerArrayMap;
-var InnerArrayReverse;
-var InnerArraySome;
-var InnerArraySort;
-var IsNaN;
-
-utils.Import(function(from) {
- ArrayFrom = from.ArrayFrom;
- InnerArrayCopyWithin = from.InnerArrayCopyWithin;
- InnerArrayEvery = from.InnerArrayEvery;
- InnerArrayFill = from.InnerArrayFill;
- InnerArrayFilter = from.InnerArrayFilter;
- InnerArrayFind = from.InnerArrayFind;
- InnerArrayFindIndex = from.InnerArrayFindIndex;
- InnerArrayForEach = from.InnerArrayForEach;
- InnerArrayIndexOf = from.InnerArrayIndexOf;
- InnerArrayLastIndexOf = from.InnerArrayLastIndexOf;
- InnerArrayMap = from.InnerArrayMap;
- InnerArrayReverse = from.InnerArrayReverse;
- InnerArraySome = from.InnerArraySome;
- InnerArraySort = from.InnerArraySort;
- IsNaN = from.IsNaN;
-});
-
// -------------------------------------------------------------------
function ConstructTypedArray(constructor, array) {
@@ -95,7 +58,7 @@
var length = %_TypedArrayGetLength(this);
// TODO(littledan): Replace with a memcpy for better performance
- return InnerArrayCopyWithin(target, start, end, this, length);
+ return $innerArrayCopyWithin(target, start, end, this, length);
}
%FunctionSetLength(TypedArrayCopyWithin, 2);
@@ -105,7 +68,7 @@
var length = %_TypedArrayGetLength(this);
- return InnerArrayEvery(f, receiver, this, length);
+ return $innerArrayEvery(f, receiver, this, length);
}
%FunctionSetLength(TypedArrayEvery, 1);
@@ -115,7 +78,7 @@
var length = %_TypedArrayGetLength(this);
- InnerArrayForEach(f, receiver, this, length);
+ $innerArrayForEach(f, receiver, this, length);
}
%FunctionSetLength(TypedArrayForEach, 1);
@@ -125,7 +88,7 @@
var length = %_TypedArrayGetLength(this);
- return InnerArrayFill(value, start, end, this, length);
+ return $innerArrayFill(value, start, end, this, length);
}
%FunctionSetLength(TypedArrayFill, 1);
@@ -134,7 +97,7 @@
if (!%IsTypedArray(this)) throw MakeTypeError(kNotTypedArray);
var length = %_TypedArrayGetLength(this);
- var array = InnerArrayFilter(predicate, thisArg, this, length);
+ var array = $innerArrayFilter(predicate, thisArg, this, length);
return ConstructTypedArrayLike(this, array);
}
%FunctionSetLength(TypedArrayFilter, 1);
@@ -145,7 +108,7 @@
var length = %_TypedArrayGetLength(this);
- return InnerArrayFind(predicate, thisArg, this, length);
+ return $innerArrayFind(predicate, thisArg, this, length);
}
%FunctionSetLength(TypedArrayFind, 1);
@@ -155,7 +118,7 @@
var length = %_TypedArrayGetLength(this);
- return InnerArrayFindIndex(predicate, thisArg, this, length);
+ return $innerArrayFindIndex(predicate, thisArg, this, length);
}
%FunctionSetLength(TypedArrayFindIndex, 1);
@@ -165,15 +128,15 @@
var length = %_TypedArrayGetLength(this);
- return InnerArrayReverse(this, length);
+ return $innerArrayReverse(this, length);
}
function TypedArrayComparefn(x, y) {
- if (IsNaN(x) && IsNaN(y)) {
- return IsNaN(y) ? 0 : 1;
- }
- if (IsNaN(x)) {
+ if ($isNaN(x) && $isNaN(y)) {
+ return $isNaN(y) ? 0 : 1;
+ }
+ if ($isNaN(x)) {
return 1;
}
if (x === 0 && x === y) {
@@ -199,7 +162,7 @@
comparefn = TypedArrayComparefn;
}
- return %_CallFunction(this, length, comparefn, InnerArraySort);
+ return %_CallFunction(this, length, comparefn, $innerArraySort);
}
@@ -209,7 +172,7 @@
var length = %_TypedArrayGetLength(this);
- return %_CallFunction(this, element, index, length, InnerArrayIndexOf);
+ return %_CallFunction(this, element, index, length, $innerArrayIndexOf);
}
%FunctionSetLength(TypedArrayIndexOf, 1);
@@ -221,7 +184,7 @@
var length = %_TypedArrayGetLength(this);
return %_CallFunction(this, element, index, length,
- %_ArgumentsLength(), InnerArrayLastIndexOf);
+ %_ArgumentsLength(), $innerArrayLastIndexOf);
}
%FunctionSetLength(TypedArrayLastIndexOf, 1);
@@ -233,7 +196,7 @@
// TODO(littledan): Preallocate rather than making an intermediate
// InternalArray, for better performance.
var length = %_TypedArrayGetLength(this);
- var array = InnerArrayMap(predicate, thisArg, this, length);
+ var array = $innerArrayMap(predicate, thisArg, this, length);
return ConstructTypedArrayLike(this, array);
}
%FunctionSetLength(TypedArrayMap, 1);
@@ -245,7 +208,7 @@
var length = %_TypedArrayGetLength(this);
- return InnerArraySome(f, receiver, this, length);
+ return $innerArraySome(f, receiver, this, length);
}
%FunctionSetLength(TypedArraySome, 1);
@@ -264,7 +227,7 @@
function TypedArrayFrom(source, mapfn, thisArg) {
// TODO(littledan): Investigate if there is a receiver which could be
// faster to accumulate on than Array, e.g., a TypedVector.
- var array = %_CallFunction(GlobalArray, source, mapfn, thisArg, ArrayFrom);
+ var array = %_CallFunction(GlobalArray, source, mapfn, thisArg, $arrayFrom);
return ConstructTypedArray(this, array);
}
%FunctionSetLength(TypedArrayFrom, 1);
@@ -272,13 +235,13 @@
// TODO(littledan): Fix the TypedArray proto chain (bug v8:4085).
macro EXTEND_TYPED_ARRAY(NAME)
// Set up non-enumerable functions on the object.
- utils.InstallFunctions(GlobalNAME, DONT_ENUM | DONT_DELETE | READ_ONLY, [
+ $installFunctions(GlobalNAME, DONT_ENUM | DONT_DELETE | READ_ONLY, [
"from", TypedArrayFrom,
"of", TypedArrayOf
]);
// Set up non-enumerable functions on the prototype object.
- utils.InstallFunctions(GlobalNAME.prototype, DONT_ENUM, [
+ $installFunctions(GlobalNAME.prototype, DONT_ENUM, [
"copyWithin", TypedArrayCopyWithin,
"every", TypedArrayEvery,
"fill", TypedArrayFill,
« no previous file with comments | « src/harmony-tostring.js ('k') | src/i18n.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698