Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1154743003: Revert of Hook up more import/exports in natives. (Closed)

Created:
5 years, 7 months ago by Michael Achenbach
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Hook up more import/exports in natives. (patchset #3 id:40001 of https://codereview.chromium.org/1154483002/) Reason for revert: [Sheriff] Speculative revert for gc stress failures: http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/481 Original issue's description: > Hook up more import/exports in natives. > > R=jkummerow@chromium.org > > Committed: https://crrev.com/7a918ac9658d11778f39593bfcc19d7c506defd9 > Cr-Commit-Position: refs/heads/master@{#28573} > > Committed: https://crrev.com/e13a39dd7f4062898709d7c68900677df0513995 > Cr-Commit-Position: refs/heads/master@{#28578} TBR=jkummerow@chromium.org,erik.corry@gmail.com,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/eb0024d1dbdda5f51b006dd54887404ee6c5cbfc Cr-Commit-Position: refs/heads/master@{#28584}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+517 lines, -711 lines) Patch
M src/array.js View 12 chunks +31 lines, -36 lines 0 comments Download
M src/array-iterator.js View 3 chunks +5 lines, -10 lines 0 comments Download
M src/arraybuffer.js View 2 chunks +4 lines, -3 lines 0 comments Download
M src/bootstrapper.cc View 2 chunks +1 line, -4 lines 0 comments Download
M src/collection.js View 7 chunks +8 lines, -17 lines 0 comments Download
M src/collection-iterator.js View 3 chunks +4 lines, -4 lines 0 comments Download
M src/date.js View 7 chunks +12 lines, -10 lines 0 comments Download
M src/generator.js View 3 chunks +5 lines, -14 lines 0 comments Download
M src/harmony-array.js View 12 chunks +17 lines, -23 lines 0 comments Download
M src/harmony-array-includes.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-object.js View 3 chunks +2 lines, -13 lines 0 comments Download
M src/harmony-reflect.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-tostring.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-typedarray.js View 17 chunks +20 lines, -57 lines 0 comments Download
M src/i18n.js View 33 chunks +67 lines, -83 lines 0 comments Download
M src/iterator-prototype.js View 1 chunk +1 line, -1 line 0 comments Download
M src/json.js View 5 chunks +4 lines, -6 lines 0 comments Download
M src/macros.py View 1 chunk +1 line, -1 line 0 comments Download
M src/math.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/messages.js View 13 chunks +28 lines, -33 lines 0 comments Download
M src/object-observe.js View 7 chunks +9 lines, -17 lines 0 comments Download
M src/prologue.js View 1 chunk +11 lines, -180 lines 0 comments Download
M src/promise.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/proxy.js View 4 chunks +9 lines, -21 lines 0 comments Download
M src/regexp.js View 16 chunks +35 lines, -38 lines 0 comments Download
M src/string.js View 13 chunks +20 lines, -26 lines 0 comments Download
M src/string-iterator.js View 5 chunks +6 lines, -15 lines 0 comments Download
M src/symbol.js View 5 chunks +5 lines, -14 lines 0 comments Download
M src/third_party/fdlibm/fdlibm.js View 1 chunk +1 line, -1 line 0 comments Download
M src/typedarray.js View 4 chunks +26 lines, -25 lines 0 comments Download
M src/uri.js View 1 chunk +1 line, -1 line 0 comments Download
M src/v8natives.js View 17 chunks +173 lines, -47 lines 0 comments Download
M src/weak-collection.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/compiler/jsnatives.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Michael Achenbach
Created Revert of Hook up more import/exports in natives.
5 years, 7 months ago (2015-05-22 11:20:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154743003/1
5 years, 7 months ago (2015-05-22 11:21:11 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-22 11:21:39 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/eb0024d1dbdda5f51b006dd54887404ee6c5cbfc Cr-Commit-Position: refs/heads/master@{#28584}
5 years, 7 months ago (2015-05-22 11:21:55 UTC) #4
Yang
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1149773003/ by yangguo@chromium.org. ...
5 years, 7 months ago (2015-05-26 07:23:32 UTC) #5
Yang
5 years, 7 months ago (2015-05-26 07:32:01 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1156093002/ by yangguo@chromium.org.

The reason for reverting is: revert due to failures..

Powered by Google App Engine
This is Rietveld 408576698