Oilpan: Unpoison orphaned large objects before zapping

Oilpan: Unpoison orphaned large objects before zapping

To zap orphaned large objects, we need to unpoison the area.
Otherwise ASan detects the error, although it seems there has been
no orphaned large objects so far (by accident).

We're already doing that for orphaned normal pages.

This CL also adds a couple of ASSERTs that would be helpful.

BUG=420515
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195782

[haraken, 2015-05-22 02:17:18]

haraken@chromium.org changed reviewers:
+ keishi@chromium.org, oilpan-reviews@chromium.org

[haraken, 2015-05-22 02:17:19]

PTAL

[sof, 2015-05-22 05:42:06]

sigbjornf@opera.com changed reviewers:
+ sigbjornf@opera.com

[sof, 2015-05-22 05:42:07]

https://codereview.chromium.org/1154733002/diff/20001/Source/platform/heap/He...
File Source/platform/heap/Heap.cpp (left):

https://codereview.chromium.org/1154733002/diff/20001/Source/platform/heap/He...
Source/platform/heap/Heap.cpp:1491: BasePage::markOrphaned();
Why isn't it re-poisoned afterwards?

https://codereview.chromium.org/1154733002/diff/20001/Source/platform/heap/He...
File Source/platform/heap/Heap.cpp (right):

https://codereview.chromium.org/1154733002/diff/20001/Source/platform/heap/He...
Source/platform/heap/Heap.cpp:1497: ASAN_UNPOISON_MEMORY_REGION(payload(),
payloadSize());
If you pass (payload,size) as args to BasePage::markOrphaned(), you can common
up some code.

[haraken, 2015-05-22 10:18:25]

>
https://codereview.chromium.org/1154733002/diff/20001/Source/platform/heap/He...
> File Source/platform/heap/Heap.cpp (left):
> 
>
https://codereview.chromium.org/1154733002/diff/20001/Source/platform/heap/He...
> Source/platform/heap/Heap.cpp:1491: BasePage::markOrphaned();
> Why isn't it re-poisoned afterwards?

Nice catch. done.

>
https://codereview.chromium.org/1154733002/diff/20001/Source/platform/heap/He...
> File Source/platform/heap/Heap.cpp (right):
> 
>
https://codereview.chromium.org/1154733002/diff/20001/Source/platform/heap/He...
> Source/platform/heap/Heap.cpp:1497: ASAN_UNPOISON_MEMORY_REGION(payload(),
> payloadSize());
> If you pass (payload,size) as args to BasePage::markOrphaned(), you can common
> up some code.

Done.

[sof, 2015-05-22 10:49:32]

lgtm

[haraken, 2015-05-22 11:12:09]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2015-05-22 11:12:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1154733002/40001

[commit-bot: I haz the power, 2015-05-22 12:25:12]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195782

[sof, 2015-05-22 13:01:59]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1146393004/ by sigbjornf@opera.com.

The reason for reverting is: Broke ASAN compilation,


http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20ASAN/bu....