Issue 115473002: [Android] Don't rely on INJECT_EVENTS exception for dismissing dialogs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115473002: [Android] Don't rely on INJECT_EVENTS exception for dismissing dialogs. (Closed)

Created:
7 years ago by frankf

Modified:
7 years ago

Reviewers:
gone

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android] Don't rely on INJECT_EVENTS exception for dismissing dialogs. The failure could manifest in other ways. For example some tests downstream assert whether activity has focus. BUG=None R=dfalcantara@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240755

Patch Set 1 : #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -6 lines)			Patch
	M	build/android/pylib/instrumentation/test_runner.py	View		1 chunk	+5 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r240755 (presubmit successful).

Expand Messages | Collapse Messages