Issue 1154703002: Avoid lint presubmit error in dump_dependency_json

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1154703002: Avoid lint presubmit error in dump_dependency_json (Closed)

Created:
5 years, 7 months ago by scottmg

Modified:
5 years, 7 months ago

Reviewers:
Nico

CC:
gyp-developer_googlegroups.com

Base URL:
https://chromium.googlesource.com/external/gyp.git@master

Target Ref:
refs/heads/master

Project:
gyp

Visibility:
Public.

More Reviews

Description

Avoid lint presubmit error in dump_dependency_json Otherwise: scottmg:~/work/cr/src/tools/gyp (land-shared-library-fix)]$ git cl land Using 50% similarity for rename/copy detection. Override with --similarity. Running presubmit commit checks ... ** Presubmit ERRORS ** Pylint (437 files) (50.14s) failed ************* Module gyp.generator.dump_dependency_json W: 65, 2: Global variable 'generator_filelist_paths' undefined at the module level (global-variable-undefined) Presubmit checks took 51.0s to calculate. R=thakis@chromium.org Committed: https://chromium.googlesource.com/external/gyp/+/29e94a3285ee899d14d5e56a6001682620d3778f

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	pylib/gyp/generator/dump_dependency_json.py	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scottmg

5 years, 7 months ago (2015-05-22 02:42:41 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
29e94a3285ee899d14d5e56a6001682620d3778f (presubmit successful).

Expand Messages | Collapse Messages