Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 11547014: Make Maps constructor explicit. (Closed)

Created:
8 years ago by hans
Modified:
8 years ago
Reviewers:
Mark Seaborn
CC:
chromium-reviews, Markus (顧孟勤), Mark Seaborn
Visibility:
Public.

Description

Make Maps constructor explicit. BUG=https://code.google.com/p/chromium/issues/detail?id=163357 Committed: https://code.google.com/p/seccompsandbox/source/detail?r=189

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M maps.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
hans
Hi Mark, can you take a look at this? I'm looking into cleaning up missing/superfluous ...
8 years ago (2012-12-12 10:19:58 UTC) #1
Mark Seaborn
LGTM as long as this compiles OK (e.g. run "make test" in this directory). Are ...
8 years ago (2012-12-12 17:43:12 UTC) #2
hans
On 2012/12/12 17:43:12, Mark Seaborn wrote: > LGTM as long as this compiles OK (e.g. ...
8 years ago (2012-12-12 17:45:32 UTC) #3
Markus (顧孟勤)
8 years ago (2012-12-12 17:57:02 UTC) #4
It is somewhat obsolete, but we still keep it around for reference. We'll
probably revisit that decision in the new year, as the new sandbox has been
maturing nicely.


Markus

On Wednesday, December 12, 2012,  <mseaborn@chromium.org> wrote:
> LGTM as long as this compiles OK (e.g. run "make test" in this directory).
>
> Are we still using this repo, though?  Markus, is this obsoleted by the
> seccomp-bpf sandbox yet?  Should we stop pulling the original seccomp
sandbox
> into the Chromium repo?
>
> https://codereview.chromium.org/11547014/
>

Powered by Google App Engine
This is Rietveld 408576698