Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 1154673005: Formalize a RenderFrameHost::AddMessageToConsole() API. (Closed)

Created:
5 years, 6 months ago by Peter Beverloo
Modified:
5 years, 6 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, pfeldman, yurys
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Formalize a RenderFrameHost::AddMessageToConsole() API. This CL adds a new API to RenderFrameHost allowing consumers to add a new message to the DevTools console. There's currently one feature doing this by manually sending an IPC message, but that doesn't scale well, and I'm in the process of adding a second user. BUG= Committed: https://crrev.com/4eb24200b1402c38f37ea02eff707db2710f294d Cr-Commit-Position: refs/heads/master@{#332374}

Patch Set 1 #

Patch Set 2 : Android fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -14 lines) Patch
M content/browser/frame_host/render_frame_host_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_android.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M content/common/devtools_messages.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/common/frame_messages.h View 2 chunks +6 lines, -0 lines 0 comments Download
M content/public/browser/render_frame_host.h View 2 chunks +5 lines, -0 lines 0 comments Download
M content/renderer/devtools/devtools_agent.h View 2 chunks +3 lines, -2 lines 0 comments Download
M content/renderer/devtools/devtools_agent.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M content/renderer/render_frame_impl.h View 2 chunks +3 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Peter Beverloo
+pfeldman
5 years, 6 months ago (2015-05-29 13:45:55 UTC) #2
Mike West
Once pfeldman@ is happy with the implementation, moving the IPC from devtools to frame LGTM.
5 years, 6 months ago (2015-05-29 13:57:45 UTC) #4
Charlie Reis
content/public drive-by: We generally require there to be a caller outside content/ when adding something ...
5 years, 6 months ago (2015-05-29 22:39:50 UTC) #6
Peter Beverloo
On 2015/05/29 22:39:50, Charlie Reis wrote: > content/public drive-by: We generally require there to be ...
5 years, 6 months ago (2015-05-29 22:42:26 UTC) #7
Charlie Reis
On 2015/05/29 22:42:26, Peter Beverloo wrote: > On 2015/05/29 22:39:50, Charlie Reis wrote: > > ...
5 years, 6 months ago (2015-05-29 22:46:06 UTC) #9
pfeldman
lgtm
5 years, 6 months ago (2015-05-30 19:19:27 UTC) #10
jam
lgtm
5 years, 6 months ago (2015-06-01 21:34:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154673005/20001
5 years, 6 months ago (2015-06-02 11:34:48 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-02 12:45:26 UTC) #15
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 12:46:30 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4eb24200b1402c38f37ea02eff707db2710f294d
Cr-Commit-Position: refs/heads/master@{#332374}

Powered by Google App Engine
This is Rietveld 408576698