Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1758)

Unified Diff: sdk/lib/isolate/isolate.dart

Issue 1154673004: Add "checked" parameter to Isolate.spawnUri. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Add test. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/isolate/isolate.dart
diff --git a/sdk/lib/isolate/isolate.dart b/sdk/lib/isolate/isolate.dart
index 8c46d6047e28c56ae62455f2156588a5935d6d17..a9c52c206b6dd26c4061a7c1edde2fe14d607943 100644
--- a/sdk/lib/isolate/isolate.dart
+++ b/sdk/lib/isolate/isolate.dart
@@ -194,7 +194,17 @@ class Isolate {
* before it starts running.
* To resume the isolate, call `isolate.resume(isolate.pauseCapability)`.
*
- * WARNING: The `pause` parameter is not implemented on all platforms yet.
+ * If the [checked] parameter is set to `true` or `false`,
+ * the new isolate will run code in checked mode,
+ * respectively in production mode, if possible.
+ * If the parameter is omitted, it defaults to `true`
+ * if the current isolate is running in checked mode
+ * and `false` otherwise.
Ivan Posva 2015/05/29 15:18:17 You could also say that it inherits the checked mo
Lasse Reichstein Nielsen 2015/06/02 15:26:44 Done.
+ *
+ * If the isolate code was pre-compiled, it may not be possible to change
+ * the checked mode setting dynamically.
+ *
+ * WARNING: The [checked] parameter is not implemented on all platforms yet.
*
* Returns a future that will complete with an [Isolate] instance if the
* spawning succeeded. It will complete with an error otherwise.
@@ -204,6 +214,7 @@ class Isolate {
List<String> args,
var message,
{bool paused: false,
+ bool checked,
Uri packageRoot});
Ivan Posva 2015/05/29 15:18:17 The order in the function signature and in the doc
Lasse Reichstein Nielsen 2015/06/02 15:26:44 Done.
/**

Powered by Google App Engine
This is Rietveld 408576698