Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Unified Diff: runtime/lib/isolate_patch.dart

Issue 1154673004: Add "checked" parameter to Isolate.spawnUri. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Add test. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/lib/isolate_patch.dart
diff --git a/runtime/lib/isolate_patch.dart b/runtime/lib/isolate_patch.dart
index 100d951a647eff1d70e0cb69176bc54a1a069e32..2d20d0e5559d7e822a96cf1cd450d7c0b133d692 100644
--- a/runtime/lib/isolate_patch.dart
+++ b/runtime/lib/isolate_patch.dart
@@ -303,7 +303,7 @@ patch class Isolate {
/* patch */ static Future<Isolate> spawnUri(
Uri uri, List<String> args, var message,
- { bool paused: false, Uri packageRoot }) {
+ { bool paused: false, bool checked, Uri packageRoot }) {
// `paused` isn't handled yet.
RawReceivePort readyPort;
try {
@@ -311,8 +311,12 @@ patch class Isolate {
readyPort = new RawReceivePort();
var packageRootString =
(packageRoot == null) ? null : packageRoot.toString();
+ if (checked == null) {
+ checked = false;
+ assert((checked = true));
Ivan Posva 2015/05/29 15:18:17 ?
Lasse Reichstein Nielsen 2015/06/02 15:26:44 Just a way to get the checked-mode state of the cu
Ivan Posva 2015/06/02 17:49:31 Assertions and checked mode are two different conc
+ }
_spawnUri(readyPort.sendPort, uri.toString(), args, message,
- paused, packageRootString);
+ paused, checked, packageRootString);
Ivan Posva 2015/05/29 15:18:17 Please pass the exact parameter down to the native
Lasse Reichstein Nielsen 2015/06/02 15:26:44 Done.
Completer completer = new Completer<Isolate>.sync();
readyPort.handler = (readyMessage) {
readyPort.close();
@@ -354,7 +358,7 @@ patch class Isolate {
static void _spawnUri(SendPort readyPort, String uri,
List<String> args, var message,
- bool paused, String packageRoot)
+ bool paused, bool checked, String packageRoot)
native "Isolate_spawnUri";
static void _sendOOB(port, msg) native "Isolate_sendOOB";

Powered by Google App Engine
This is Rietveld 408576698