Add "checked" parameter to Isolate.spawnUri.

runtime/lib/isolate_patch.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import "dart:collection" show HashMap;
 import "dart:_internal";
 
 patch class ReceivePort {
   /* patch */ factory ReceivePort() = _ReceivePortImpl;
 
@@ skipping 285 matching lines @@
     } catch (e, st) {
       if (readyPort != null) {
         readyPort.close();
       }
       return new Future<Isolate>.error(e, st);
     };
   }
 
   /* patch */ static Future<Isolate> spawnUri(
       Uri uri, List<String> args, var message,
-      { bool paused: false, Uri packageRoot }) {
+      { bool paused: false, bool checked, Uri packageRoot }) {
     // `paused` isn't handled yet.
     RawReceivePort readyPort;
     try {
       // The VM will invoke [_startIsolate] and not `main`.
       readyPort = new RawReceivePort();
       var packageRootString =
           (packageRoot == null) ? null : packageRoot.toString();
+      if (checked == null) {
+        checked = false;
+        assert((checked = true));

[Ivan Posva, 2015/05/29 15:18:17]

?

[Lasse Reichstein Nielsen, 2015/06/02 15:26:44]

Just a way to get the checked-mode state of the current isolate in Dart code.
If the VM allows assertion statements to be different from type assertions, then
it's probably not safe.

[Ivan Posva, 2015/06/02 17:49:31]

Assertions and checked mode are two different concepts in the VM which are both
enabled by passing the --checked flag on the command line. They can be enabled
individually if so desired.

+      }
       _spawnUri(readyPort.sendPort, uri.toString(), args, message,
-                paused, packageRootString);
+                paused, checked, packageRootString);

[Ivan Posva, 2015/05/29 15:18:17]

Please pass the exact parameter down to the native code, so that we can inherit
when setting up the isolate spawn state.

[Lasse Reichstein Nielsen, 2015/06/02 15:26:44]

Done.

       Completer completer = new Completer<Isolate>.sync();
       readyPort.handler = (readyMessage) {
         readyPort.close();
         assert(readyMessage is List);
         assert(readyMessage.length == 2);
         SendPort controlPort = readyMessage[0];
         List capabilities = readyMessage[1];
         completer.complete(new Isolate(controlPort,
                                        pauseCapability: capabilities[0],
                                        terminateCapability: capabilities[1]));
@@ skipping 21 matching lines @@
   static const _DEL_ERROR = 8;
   static const _ERROR_FATAL = 9;
 
 
   static void _spawnFunction(SendPort readyPort, Function topLevelFunction,
                              var message, bool paused)
       native "Isolate_spawnFunction";
 
   static void _spawnUri(SendPort readyPort, String uri,
                         List<String> args, var message,
-                        bool paused, String packageRoot)
+                        bool paused, bool checked, String packageRoot)
       native "Isolate_spawnUri";
 
   static void _sendOOB(port, msg) native "Isolate_sendOOB";
 
   /* patch */ void _pause(Capability resumeCapability) {
     var msg = new List(4)
         ..[0] = 0  // Make room for OOB message type.
         ..[1] = _PAUSE
         ..[2] = pauseCapability
         ..[3] = resumeCapability;
@@ skipping 75 matching lines @@
   static Isolate _getCurrentIsolate() {
     List portAndCapabilities = _getPortAndCapabilitiesOfCurrentIsolate();
     return new Isolate(portAndCapabilities[0],
                        pauseCapability: portAndCapabilities[1],
                        terminateCapability: portAndCapabilities[2]);
   }
 
   static List _getPortAndCapabilitiesOfCurrentIsolate()
       native "Isolate_getPortAndCapabilitiesOfCurrentIsolate";
 }