Add "checked" parameter to Isolate.spawnUri.

runtime/lib/isolate.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/assert.h"
 #include "vm/bootstrap_natives.h"
 #include "vm/class_finalizer.h"
 #include "vm/dart.h"
 #include "vm/dart_api_impl.h"
 #include "vm/dart_entry.h"
@@ skipping 164 matching lines @@
   Isolate* child_isolate = reinterpret_cast<Isolate*>(
       (callback)(state->script_url(),
                  state->function_name(),
                  state->package_root(),
                  init_data,
                  error));
   if (child_isolate == NULL) {
     return false;
   }
   if (!state->is_spawn_uri()) {
-    // For isolates spawned using the spawnFunction semantics we set
+    child_isolate->set_strict_compilation(parent_isolate->strict_compilation());

[Ivan Posva, 2015/05/29 15:18:17]

This should be handled when we create the spawn state. Basically in
spawnFunction we inherit from the parent isolate and in spawnUri we should
handle the tri-state parameter.

[Lasse Reichstein Nielsen, 2015/06/02 15:26:44]

Done.

+
+    // For isolates spawned using the spawn semantics we set
     // the origin_id to the origin_id of the parent isolate.
     child_isolate->set_origin_id(parent_isolate->origin_id());
+  } else {
+    child_isolate->set_strict_compilation(state->checked_mode());
   }
   state->set_isolate(reinterpret_cast<Isolate*>(child_isolate));
   return true;
 }
 
 
 static void Spawn(Isolate* parent_isolate, IsolateSpawnState* state) {
   Thread::ExitIsolate();
   // Create a new isolate.
   char* error = NULL;
@@ skipping 38 matching lines @@
       return Object::null();
     }
   }
   const String& msg = String::Handle(String::New(
       "Isolate.spawn expects to be passed a static or top-level function"));
   Exceptions::ThrowArgumentError(msg);
   return Object::null();
 }
 
 
-DEFINE_NATIVE_ENTRY(Isolate_spawnUri, 6) {
+DEFINE_NATIVE_ENTRY(Isolate_spawnUri, 7) {
   GET_NON_NULL_NATIVE_ARGUMENT(SendPort, port, arguments->NativeArgAt(0));
   GET_NON_NULL_NATIVE_ARGUMENT(String, uri, arguments->NativeArgAt(1));
   GET_NON_NULL_NATIVE_ARGUMENT(Instance, args, arguments->NativeArgAt(2));
   GET_NON_NULL_NATIVE_ARGUMENT(Instance, message, arguments->NativeArgAt(3));
   GET_NON_NULL_NATIVE_ARGUMENT(Bool, paused, arguments->NativeArgAt(4));
-  GET_NATIVE_ARGUMENT(String, package_root, arguments->NativeArgAt(5));
+  GET_NON_NULL_NATIVE_ARGUMENT(Bool, checked, arguments->NativeArgAt(5));
+  GET_NATIVE_ARGUMENT(String, package_root, arguments->NativeArgAt(6));
 
   // Canonicalize the uri with respect to the current isolate.
   char* error = NULL;
   char* canonical_uri = NULL;
   const Library& root_lib =
       Library::Handle(isolate->object_store()->root_library());
   if (!CanonicalizeUri(isolate, root_lib, uri,
                        &canonical_uri, &error)) {
     const String& msg = String::Handle(String::New(error));
     ThrowIsolateSpawnException(msg);
   }
 
   char* utf8_package_root = NULL;
   if (!package_root.IsNull()) {
     const intptr_t len = Utf8::Length(package_root);
     utf8_package_root = zone->Alloc<char>(len + 1);
     package_root.ToUTF8(reinterpret_cast<uint8_t*>(utf8_package_root), len);
     utf8_package_root[len] = '\0';
   }
 
   Spawn(isolate, new IsolateSpawnState(port.Id(),
                                        canonical_uri,
                                        utf8_package_root,
                                        args,
                                        message,
-                                       paused.value()));
+                                       paused.value(),
+                                       checked.value()));
   return Object::null();
 }
 
 
 DEFINE_NATIVE_ENTRY(Isolate_getPortAndCapabilitiesOfCurrentIsolate, 0) {
   const Array& result = Array::Handle(Array::New(3));
   result.SetAt(0, SendPort::Handle(SendPort::New(isolate->main_port())));
   result.SetAt(1, Capability::Handle(
                       Capability::New(isolate->pause_capability())));
   result.SetAt(2, Capability::Handle(
@@ skipping 13 matching lines @@
   MessageWriter writer(&data, &allocator, false);
   writer.WriteMessage(msg);
 
   PortMap::PostMessage(new Message(port.Id(),
                                    data, writer.BytesWritten(),
                                    Message::kOOBPriority));
   return Object::null();
 }
 
 }  // namespace dart