Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1154633003: Add luci-go's isolate tool, downloaded via runhooks. (Closed)

Created:
5 years, 7 months ago by M-A Ruel
Modified:
5 years, 7 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, tandri_chromium.org
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add luci-go's isolate tool, downloaded via runhooks. R=vadimsh@chromium.org BUG= Committed: https://crrev.com/4fbba012ab94bf81393095e6e3a55a6134c4957d Cr-Commit-Position: refs/heads/master@{#331184}

Patch Set 1 #

Total comments: 5

Patch Set 2 : fix .gitignore on windows #

Patch Set 3 : Fix support for --dump-json #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
M .gitignore View 1 1 chunk +3 lines, -0 lines 0 comments Download
M DEPS View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
A tools/luci-go/linux64/isolate.sha1 View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A tools/luci-go/mac64/isolate.sha1 View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A tools/luci-go/win64/isolate.exe.sha1 View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
M-A Ruel
5 years, 7 months ago (2015-05-22 19:15:28 UTC) #1
Vadim Sh.
lgtm with suggestion https://codereview.chromium.org/1154633003/diff/1/.gitignore File .gitignore (right): https://codereview.chromium.org/1154633003/diff/1/.gitignore#newcode258 .gitignore:258: /tools/luci-go/win64/isolate isolate.exe https://codereview.chromium.org/1154633003/diff/1/DEPS File DEPS (right): ...
5 years, 7 months ago (2015-05-22 19:24:06 UTC) #2
M-A Ruel
https://codereview.chromium.org/1154633003/diff/1/.gitignore File .gitignore (right): https://codereview.chromium.org/1154633003/diff/1/.gitignore#newcode258 .gitignore:258: /tools/luci-go/win64/isolate On 2015/05/22 19:24:05, Vadim Sh. wrote: > isolate.exe ...
5 years, 7 months ago (2015-05-22 19:29:09 UTC) #3
Vadim Sh.
https://codereview.chromium.org/1154633003/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/1154633003/diff/1/DEPS#newcode692 DEPS:692: '-d', 'src/tools/luci-go/linux64', On 2015/05/22 19:29:09, M-A Ruel wrote: > ...
5 years, 7 months ago (2015-05-22 19:30:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154633003/20001
5 years, 7 months ago (2015-05-22 19:31:16 UTC) #7
M-A Ruel
On 2015/05/22 19:31:16, I haz the power - commit-bot wrote: > CQ is trying da ...
5 years, 7 months ago (2015-05-22 19:32:47 UTC) #9
M-A Ruel
On 2015/05/22 19:32:47, M-A Ruel wrote: > On 2015/05/22 19:31:16, I haz the power - ...
5 years, 7 months ago (2015-05-22 20:08:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154633003/40001
5 years, 7 months ago (2015-05-22 20:09:48 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-22 21:52:40 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 21:57:00 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4fbba012ab94bf81393095e6e3a55a6134c4957d
Cr-Commit-Position: refs/heads/master@{#331184}

Powered by Google App Engine
This is Rietveld 408576698