Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 115463002: Land Recent QUIC Changes. (Closed)

Created:
7 years ago by ramant (doing other things)
Modified:
7 years ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Land Recent QUIC Changes. Add convenience HighestPriority and LowestPriority methods to QuicUtils Merge internal change: 58122394 https://codereview.chromium.org/112463003/ Change QUIC to only ack every other packet when there are no losses within the last four received packets. Merge internal change: 58111242 https://codereview.chromium.org/113123004/ Add a version() convenience method to ReliableQuicStream. Merge internal change: 58110960 https://codereview.chromium.org/112273003/ Fix two tests that fail when FLAGS_enable_quic_pacing is enabled Merge internal change: 58101756 https://codereview.chromium.org/115393003/ Remove deprecated flag FLAGS_pad_quic_handshake_packets. Merge internal change: 58101024 https://codereview.chromium.org/114923007/ Remove the is_server argument from the QuicSession constructor. In a previous CL, I removed this from TestSession, but I missed, that it's an argument of the main QuicSession constructor. Merge internal change: 58059515 https://codereview.chromium.org/102313005/ Fix QUIC's TCP style retransmission logic to only send a maximum of 2 packets per incoming ack instead of 10. Merge internal change: 58059328 https://codereview.chromium.org/109993008/ Remove redundant |is_server| argument from TestSession and call the connection's is_server() method instead. Merge internal change: 58047118 https://codereview.chromium.org/110373004/ Minor cleanup of QUIC MockConnection and PacketSavingConnection constructors. Merge internal change: 58042657 https://codereview.chromium.org/114933003/ Cleanup in QUIC to merge the previous_transmissions_map in QuicSentPacketManager with the unacked_packets map. Merge internal change: 58011531 https://codereview.chromium.org/109323012/ R=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240972

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+372 lines, -427 lines) Patch
net/quic/quic_client_session.cc View 1 chunk +1 line, -1 line 0 comments Download
net/quic/quic_client_session_test.cc View 2 chunks +2 lines, -4 lines 0 comments Download
net/quic/quic_config_test.cc View 1 chunk +2 lines, -0 lines 0 comments Download
net/quic/quic_connection.cc View 2 chunks +5 lines, -6 lines 0 comments Download
net/quic/quic_connection_test.cc View 6 chunks +41 lines, -12 lines 0 comments Download
net/quic/quic_crypto_client_stream_test.cc View 4 chunks +6 lines, -7 lines 0 comments Download
net/quic/quic_crypto_server_stream_test.cc View 6 chunks +10 lines, -23 lines 0 comments Download
net/quic/quic_crypto_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
net/quic/quic_crypto_stream_test.cc View 2 chunks +2 lines, -4 lines 0 comments Download
net/quic/quic_data_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
net/quic/quic_data_stream_test.cc View 16 chunks +19 lines, -24 lines 0 comments Download
net/quic/quic_packet_creator.h View 1 chunk +0 lines, -2 lines 0 comments Download
net/quic/quic_packet_creator.cc View 2 chunks +1 line, -7 lines 0 comments Download
net/quic/quic_packet_creator_test.cc View 2 chunks +0 lines, -5 lines 0 comments Download
net/quic/quic_received_packet_manager.h View 2 chunks +7 lines, -0 lines 0 comments Download
net/quic/quic_received_packet_manager.cc View 4 chunks +23 lines, -0 lines 0 comments Download
net/quic/quic_reliable_client_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
net/quic/quic_sent_packet_manager.h View 3 chunks +7 lines, -13 lines 0 comments Download
net/quic/quic_sent_packet_manager.cc View 8 chunks +37 lines, -62 lines 0 comments Download
net/quic/quic_sent_packet_manager_test.cc View 3 chunks +8 lines, -8 lines 0 comments Download
net/quic/quic_session.h View 3 chunks +2 lines, -4 lines 0 comments Download
net/quic/quic_session.cc View 3 chunks +4 lines, -6 lines 0 comments Download
net/quic/quic_session_test.cc View 7 chunks +10 lines, -11 lines 0 comments Download
net/quic/quic_stream_sequencer_test.cc View 2 chunks +5 lines, -3 lines 0 comments Download
net/quic/quic_utils.h View 1 chunk +4 lines, -0 lines 0 comments Download
net/quic/quic_utils.cc View 2 chunks +11 lines, -0 lines 0 comments Download
net/quic/reliable_quic_stream.h View 1 chunk +2 lines, -0 lines 0 comments Download
net/quic/reliable_quic_stream.cc View 1 chunk +4 lines, -0 lines 0 comments Download
net/quic/reliable_quic_stream_test.cc View 3 chunks +5 lines, -6 lines 0 comments Download
net/quic/test_tools/crypto_test_utils.cc View 2 chunks +4 lines, -14 lines 0 comments Download
net/quic/test_tools/quic_sent_packet_manager_peer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
net/quic/test_tools/quic_test_utils.h View 6 chunks +18 lines, -11 lines 0 comments Download
net/quic/test_tools/quic_test_utils.cc View 4 chunks +32 lines, -21 lines 0 comments Download
net/tools/quic/end_to_end_test.cc View 6 chunks +30 lines, -67 lines 0 comments Download
net/tools/quic/quic_client_session.cc View 1 chunk +1 line, -1 line 0 comments Download
net/tools/quic/quic_client_session_test.cc View 2 chunks +1 line, -3 lines 0 comments Download
net/tools/quic/quic_dispatcher_test.cc View 8 chunks +15 lines, -26 lines 0 comments Download
net/tools/quic/quic_server_session.cc View 1 chunk +1 line, -1 line 0 comments Download
net/tools/quic/quic_server_session_test.cc View 2 chunks +2 lines, -5 lines 0 comments Download
net/tools/quic/quic_spdy_client_stream_test.cc View 2 chunks +1 line, -2 lines 0 comments Download
net/tools/quic/quic_spdy_server_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
net/tools/quic/quic_time_wait_list_manager_test.cc View 6 chunks +14 lines, -14 lines 0 comments Download
net/tools/quic/test_tools/quic_test_utils.h View 4 chunks +11 lines, -19 lines 0 comments Download
net/tools/quic/test_tools/quic_test_utils.cc View 2 chunks +18 lines, -29 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ramant (doing other things)
7 years ago (2013-12-13 19:37:24 UTC) #1
Ryan Hamilton
lgtm
7 years ago (2013-12-13 19:47:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/115463002/1
7 years ago (2013-12-13 22:36:31 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-16 19:42:06 UTC) #4
Message was sent while issue was closed.
Change committed as 240972

Powered by Google App Engine
This is Rietveld 408576698