Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Issue 1154623006: Add documentation for SkiaLab (Closed)

Created:
5 years, 6 months ago by borenet
Modified:
5 years, 6 months ago
Reviewers:
hcm, rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Tweaks #

Patch Set 3 : More tweaks #

Total comments: 2

Patch Set 4 : Fix line breaks? #

Patch Set 5 : Moar fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -26 lines) Patch
M site/dev/testing/buildbot.md View 1 2 3 4 2 chunks +40 lines, -26 lines 0 comments Download
A site/dev/testing/skialab.md View 1 2 1 chunk +217 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
borenet
5 years, 6 months ago (2015-06-03 19:17:49 UTC) #2
rmistry
LGTM with nit. https://codereview.chromium.org/1154623006/diff/40001/site/dev/testing/buildbot.md File site/dev/testing/buildbot.md (right): https://codereview.chromium.org/1154623006/diff/40001/site/dev/testing/buildbot.md#newcode15 site/dev/testing/buildbot.md:15: * http://build.chromium.org/p/client.skia/console All these bullets are ...
5 years, 6 months ago (2015-06-04 15:23:58 UTC) #4
hcm
On 2015/06/04 15:23:58, rmistry wrote: > LGTM with nit. > > https://codereview.chromium.org/1154623006/diff/40001/site/dev/testing/buildbot.md > File site/dev/testing/buildbot.md ...
5 years, 6 months ago (2015-06-04 15:51:46 UTC) #5
hcm
On 2015/06/04 15:51:46, hcm wrote: > On 2015/06/04 15:23:58, rmistry wrote: > > LGTM with ...
5 years, 6 months ago (2015-06-04 16:00:33 UTC) #6
borenet
https://codereview.chromium.org/1154623006/diff/40001/site/dev/testing/buildbot.md File site/dev/testing/buildbot.md (right): https://codereview.chromium.org/1154623006/diff/40001/site/dev/testing/buildbot.md#newcode15 site/dev/testing/buildbot.md:15: * http://build.chromium.org/p/client.skia/console On 2015/06/04 15:23:58, rmistry wrote: > All ...
5 years, 6 months ago (2015-06-04 19:18:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154623006/80001
5 years, 6 months ago (2015-06-04 19:20:16 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-04 20:57:16 UTC) #11
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/a84f569f0dbf07da55d168bc56538078dd1d2c08

Powered by Google App Engine
This is Rietveld 408576698