Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 1154623004: Added commit_queue binaries for Windows and Linux (Closed)

Created:
5 years, 6 months ago by Sergiy Byelozyorov
Modified:
5 years, 6 months ago
Reviewers:
pgervais
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Added commit_queue binaries for Windows and Linux R=pgervais@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=295468

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
A + commit_queue View 1 chunk +1 line, -1 line 0 comments Download
A + commit_queue.bat View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Sergiy Byelozyorov
5 years, 6 months ago (2015-05-29 19:01:14 UTC) #1
pgervais
On 2015/05/29 19:01:14, Sergiy Byelozyorov wrote: lgtm
5 years, 6 months ago (2015-05-29 21:21:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154623004/1
5 years, 6 months ago (2015-05-31 00:15:12 UTC) #4
commit-bot: I haz the power
Failed to apply patch for depot_tools/commit_queue.bat: While running patch -p1 --forward --force --no-backup-if-mismatch; A depot_tools/commit_queue.bat ...
5 years, 6 months ago (2015-05-31 00:15:19 UTC) #6
chromium-reviews
Need to dcommit bat files, rietveld normalizes them, which causes CQ to fail. On Sat, ...
5 years, 6 months ago (2015-05-31 00:24:40 UTC) #7
Sergiy Byelozyorov
5 years, 6 months ago (2015-06-01 13:31:49 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 295468 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698