Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: ppapi/proxy/ppb_graphics_3d_proxy.cc

Issue 1154613006: Update pepper to not assume that SharedMemoryHandle is an int. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Another nits pass. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/proxy/ppb_graphics_3d_proxy.cc
diff --git a/ppapi/proxy/ppb_graphics_3d_proxy.cc b/ppapi/proxy/ppb_graphics_3d_proxy.cc
index 6b49914c2724d2a10c97fa0aec5a37d326138e7b..8a8c6b7f4d3746f43b06befe10448fd26983e7e4 100644
--- a/ppapi/proxy/ppb_graphics_3d_proxy.cc
+++ b/ppapi/proxy/ppb_graphics_3d_proxy.cc
@@ -33,9 +33,8 @@ const int32 kTransferBufferSize = 1024 * 1024;
base::SharedMemoryHandle TransportSHMHandle(
Dispatcher* dispatcher,
const base::SharedMemoryHandle& handle) {
- base::PlatformFile source = IPC::PlatformFileForTransitToPlatformFile(handle);
// Don't close the handle, it doesn't belong to us.
- return dispatcher->ShareHandleWithRemote(source, false);
+ return dispatcher->ShareSharedMemoryHandleWithRemote(handle);
}
#endif // !defined(OS_NACL)
@@ -240,7 +239,7 @@ void PPB_Graphics3D_Proxy::OnMsgCreate(PP_Instance instance,
if (!enter.succeeded())
return;
- base::SharedMemoryHandle handle = IPC::InvalidPlatformFileForTransit();
+ base::SharedMemoryHandle handle = base::SharedMemory::NULLHandle();
result->SetHostResource(
instance,
enter.functions()->CreateGraphics3DRaw(instance,

Powered by Google App Engine
This is Rietveld 408576698